From: "Ghanshyam Thakkar" <shyamthakkar001@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: <christian.couder@gmail.com>, <git@vger.kernel.org>,
<johannes.schindelin@gmx.de>, <newren@gmail.com>
Subject: Re: [PATCH v2] setup: remove unnecessary variable
Date: Tue, 05 Mar 2024 02:57:32 +0530 [thread overview]
Message-ID: <CZLA8TF4XG5S.KU06P62V03TV@gmail.com> (raw)
In-Reply-To: <xmqqjzmhq2vb.fsf@gitster.g>
On Mon Mar 4, 2024 at 11:46 PM IST, Junio C Hamano wrote:
> Ghanshyam Thakkar <shyamthakkar001@gmail.com> writes:
> > -
> > -test_expect_success 'template can set core.bare but overridden by command line' '
> > - test_when_finished "rm -rf subdir" &&
> > - test_when_finished "rm -rf templates" &&
> > - test_config core.bare true &&
> > - umask 0022 &&
> > - mkdir -p templates/ &&
> > - cp .git/config templates/config &&
> > - git init --no-bare --template=templates subdir &&
> > - test_path_exists subdir/.git/HEAD
> > -'
>
> This removal is a bit unexpected. Is it because we established with
> the previous test that core.bare in the template should not affect
> the outcome, so this is not worth testing?
Yes, in the previous testcase we determined that template cannot set
core.bare. Therefore, this testcase would be like testing
--bare/--no-bare option, which is already done in 0001-init.sh and
t5601-clone.sh. However, I don't have strong opinion on this. I can add
it back if you think it is worth it.
Thanks.
next prev parent reply other threads:[~2024-03-04 21:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-02 22:07 [GSOC][RFC] Heed core.bare from template config file when no command line override given, as a microproject Ghanshyam Thakkar
2024-01-04 10:24 ` Christian Couder
2024-01-04 10:39 ` Ghanshyam Thakkar
2024-01-05 2:11 ` Elijah Newren
2024-01-05 15:59 ` Junio C Hamano
2024-01-06 12:07 ` Ghanshyam Thakkar
2024-01-08 17:32 ` Junio C Hamano
2024-01-19 1:43 ` Elijah Newren
2024-02-29 13:41 ` [PATCH] setup: clarify TODO comment about ignoring core.bare Ghanshyam Thakkar
2024-02-29 19:15 ` Junio C Hamano
2024-02-29 20:58 ` Ghanshyam Thakkar
2024-03-04 15:18 ` [PATCH v2] setup: remove unnecessary variable Ghanshyam Thakkar
2024-03-04 18:16 ` Junio C Hamano
2024-03-04 21:27 ` Ghanshyam Thakkar [this message]
2024-03-04 21:53 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CZLA8TF4XG5S.KU06P62V03TV@gmail.com \
--to=shyamthakkar001@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).