git@vger.kernel.org mailing list mirror (one of many)
 help / Atom feed
* recent glob expansion breakage on Windows?
@ 2018-03-08 21:02 Laszlo Ersek
  2018-03-08 22:03 ` Jonathan Nieder
  0 siblings, 1 reply; 4+ messages in thread
From: Laszlo Ersek @ 2018-03-08 21:02 UTC (permalink / raw)
  To: public git mailing list; +Cc: Carsey, Jaben

Hi,

Jaben reports that git-send-email is suddenly failing to expand the
"*.patch" glob for him, at the Windows CMD prompt:

---------
E:\...>git send-email --suppress-cc=author --suppress-cc=self
--suppress-cc=cc --suppress-cc=sob --dry-run *.patch

No patch files specified!
---------

Whereas, moving the same patch files to another subdir, and then passing
the subdir to git-send-email, works fine.

I seem to have found some $^O based perl code in the git tree that
expands the glob manually (in place of the shell) on Windows -- however,
that code looks ancient ^W very stable, and doesn't seem to explain the
sudden breakage.

Is it possible that a separate perl update on Jaben's Windows box is
causing this? Or does the breakage look consistent with a recent git change?

Has anyone else reported something similar recently?

Thanks (and sorry about the noise; this list might not be the best place
to ask)!
Laszlo

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: recent glob expansion breakage on Windows?
  2018-03-08 21:02 recent glob expansion breakage on Windows? Laszlo Ersek
@ 2018-03-08 22:03 ` Jonathan Nieder
  2018-03-09  9:41   ` Laszlo Ersek
  0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Nieder @ 2018-03-08 22:03 UTC (permalink / raw)
  To: Laszlo Ersek; +Cc: public git mailing list, Carsey, Jaben, git-for-windows

+git-for-windows
Hi,

Laszlo Ersek wrote:

> Jaben reports that git-send-email is suddenly failing to expand the
> "*.patch" glob for him, at the Windows CMD prompt:
>
> ---------
> E:\...>git send-email --suppress-cc=author --suppress-cc=self --suppress-cc=cc --suppress-cc=sob --dry-run *.patch
>
> No patch files specified!
> ---------
>
> Whereas, moving the same patch files to another subdir, and then passing
> the subdir to git-send-email, works fine.
>
> I seem to have found some $^O based perl code in the git tree that
> expands the glob manually (in place of the shell) on Windows -- however,
> that code looks ancient ^W very stable, and doesn't seem to explain the
> sudden breakage.
>
> Is it possible that a separate perl update on Jaben's Windows box is
> causing this? Or does the breakage look consistent with a recent git change?
>
> Has anyone else reported something similar recently?

This reminds me of https://github.com/git-for-windows/git/issues/339.
There, Johannes Schindelin writes (about a different command):

| This is expected because neither PowerShell nor cmd.exe nor git.exe
| expand wildcards. Those examples you found were written with a shell
| in mind, and the shell expands wildcards (hence Git does not think
| it needs to).

That may or may not also apply to send-email.  In what version did it
work?

Thanks,
Jonathan

> Thanks (and sorry about the noise; this list might not be the best place
> to ask)!
> Laszlo

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: recent glob expansion breakage on Windows?
  2018-03-08 22:03 ` Jonathan Nieder
@ 2018-03-09  9:41   ` Laszlo Ersek
  2018-03-13 23:12     ` Carsey, Jaben
  0 siblings, 1 reply; 4+ messages in thread
From: Laszlo Ersek @ 2018-03-09  9:41 UTC (permalink / raw)
  To: Jonathan Nieder; +Cc: public git mailing list, Carsey, Jaben, git-for-windows

On 03/08/18 23:03, Jonathan Nieder wrote:
> +git-for-windows
> Hi,
> 
> Laszlo Ersek wrote:
> 
>> Jaben reports that git-send-email is suddenly failing to expand the
>> "*.patch" glob for him, at the Windows CMD prompt:
>>
>> ---------
>> E:\...>git send-email --suppress-cc=author --suppress-cc=self --suppress-cc=cc --suppress-cc=sob --dry-run *.patch
>>
>> No patch files specified!
>> ---------
>>
>> Whereas, moving the same patch files to another subdir, and then passing
>> the subdir to git-send-email, works fine.
>>
>> I seem to have found some $^O based perl code in the git tree that
>> expands the glob manually (in place of the shell) on Windows -- however,
>> that code looks ancient ^W very stable, and doesn't seem to explain the
>> sudden breakage.
>>
>> Is it possible that a separate perl update on Jaben's Windows box is
>> causing this? Or does the breakage look consistent with a recent git change?
>>
>> Has anyone else reported something similar recently?
> 
> This reminds me of https://github.com/git-for-windows/git/issues/339.
> There, Johannes Schindelin writes (about a different command):
> 
> | This is expected because neither PowerShell nor cmd.exe nor git.exe
> | expand wildcards. Those examples you found were written with a shell
> | in mind, and the shell expands wildcards (hence Git does not think
> | it needs to).
> 
> That may or may not also apply to send-email.

Thank you for the reference -- I can't say whether closing issue #339 as
WONTFIX was justified or not, but it certainly seems inconsistent with
Jaben's earlier experience (to my understanding), i.e. that git did
expand the glob.

> In what version did it work?

Jaben, can you please answer that? (One version in which it is broken is
2.14.1.windows.1.) Can you perhaps ask your teammates about their
git/windows versions (assuming the *.patch glob is expanded correctly
for them)?

Thank you, Jonathan,
Laszlo

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: recent glob expansion breakage on Windows?
  2018-03-09  9:41   ` Laszlo Ersek
@ 2018-03-13 23:12     ` Carsey, Jaben
  0 siblings, 0 replies; 4+ messages in thread
From: Carsey, Jaben @ 2018-03-13 23:12 UTC (permalink / raw)
  To: Laszlo Ersek, Jonathan Nieder; +Cc: public git mailing list, git-for-windows

I do not remember what version I was using before.  I am suddenly wondering if I previously sent single patches instead of using wildcard (which works fine).  The only person I have found doing patch series here on windows uses the directory method (put patch files there, list directory name on send-email command line).

I have updated to the 2.16.2 version and I see the same issues.

-Jaben

> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Friday, March 09, 2018 1:42 AM
> To: Jonathan Nieder <jrnieder@gmail.com>
> Cc: public git mailing list <git@vger.kernel.org>; Carsey, Jaben
> <jaben.carsey@intel.com>; git-for-windows@googlegroups.com
> Subject: Re: recent glob expansion breakage on Windows?
> Importance: High
> 
> On 03/08/18 23:03, Jonathan Nieder wrote:
> > +git-for-windows
> > Hi,
> >
> > Laszlo Ersek wrote:
> >
> >> Jaben reports that git-send-email is suddenly failing to expand the
> >> "*.patch" glob for him, at the Windows CMD prompt:
> >>
> >> ---------
> >> E:\...>git send-email --suppress-cc=author --suppress-cc=self --suppress-
> cc=cc --suppress-cc=sob --dry-run *.patch
> >>
> >> No patch files specified!
> >> ---------
> >>
> >> Whereas, moving the same patch files to another subdir, and then passing
> >> the subdir to git-send-email, works fine.
> >>
> >> I seem to have found some $^O based perl code in the git tree that
> >> expands the glob manually (in place of the shell) on Windows -- however,
> >> that code looks ancient ^W very stable, and doesn't seem to explain the
> >> sudden breakage.
> >>
> >> Is it possible that a separate perl update on Jaben's Windows box is
> >> causing this? Or does the breakage look consistent with a recent git
> change?
> >>
> >> Has anyone else reported something similar recently?
> >
> > This reminds me of https://github.com/git-for-windows/git/issues/339.
> > There, Johannes Schindelin writes (about a different command):
> >
> > | This is expected because neither PowerShell nor cmd.exe nor git.exe
> > | expand wildcards. Those examples you found were written with a shell
> > | in mind, and the shell expands wildcards (hence Git does not think
> > | it needs to).
> >
> > That may or may not also apply to send-email.
> 
> Thank you for the reference -- I can't say whether closing issue #339 as
> WONTFIX was justified or not, but it certainly seems inconsistent with
> Jaben's earlier experience (to my understanding), i.e. that git did
> expand the glob.
> 
> > In what version did it work?
> 
> Jaben, can you please answer that? (One version in which it is broken is
> 2.14.1.windows.1.) Can you perhaps ask your teammates about their
> git/windows versions (assuming the *.patch glob is expanded correctly
> for them)?
> 
> Thank you, Jonathan,
> Laszlo

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-08 21:02 recent glob expansion breakage on Windows? Laszlo Ersek
2018-03-08 22:03 ` Jonathan Nieder
2018-03-09  9:41   ` Laszlo Ersek
2018-03-13 23:12     ` Carsey, Jaben

git@vger.kernel.org mailing list mirror (one of many)

Archives are clonable:
	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
	nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
	nntp://news.gmane.org/gmane.comp.version-control.git

 note: .onion URLs require Tor: https://www.torproject.org/
       or Tor2web: https://www.tor2web.org/

AGPL code for this site: git clone https://public-inbox.org/ public-inbox