From: Ed Maste <emaste@freebsd.org>
To: "brian m. carlson" <sandals@crustytoothpaste.net>, git@vger.kernel.org
Cc: avarab@gmail.com
Subject: Re: [PATCH] ci: add Cirrus-CI config for FreeBSD CI
Date: Tue, 26 Nov 2019 08:31:46 -0500 [thread overview]
Message-ID: <CAPyFy2A8x99fa3ti1E9Fqkcpw8RQBn5AJaL+u5g=e0qeMeyf2A@mail.gmail.com> (raw)
In-Reply-To: <20191126004419.GE2404748@camp.crustytoothpaste.net>
On Mon, 25 Nov 2019 at 19:44, brian m. carlson
<sandals@crustytoothpaste.net> wrote:
>
> On 2019-11-25 at 20:37:40, Ed Maste wrote:
> > From: Ed Maste <emaste@freebsd.org>
> >
> > Cirrus-CI is relatively unique among hosted CI providers in supporting
> > FreeBSD (in addition to Linux, Windows, and macOS). Add a Cirrus-CI
> > config to facilitate building and testing on FreeBSD.
> >
> > Signed-off-by: Ed Maste <emaste@freebsd.org>
>
> I'm all for automated testing on FreeBSD, but we would need someone to
> triage and address any failures reasonably quickly. Is that something
> you'd be okay with doing, or is there someone else who would be okay
> with doing that?
We're currently experimenting with a migration of the FreeBSD repo
from Subversion to git, so long term there will be many with a vested
interest in triaging and addressing failures. In the near term though
I'd be able to take this on.
> > 6 i18n tests are currently failing and need investigation.
> > Example result: https://cirrus-ci.com/task/5394512637067264
> > Test log: https://api.cirrus-ci.com/v1/task/5394512637067264/logs/test.log
>
> Could we fix these issues first so we don't have CI suddenly start
> failing?
Indeed, that makes sense. I think the failures may be an issue with
the test though; here's the first failure:
expecting success of 4210.6 '-c grep.patternType=fixed log --grep does not find
non-reencoded values (latin1 + locale)':
cat >expect <<-\EOF &&
latin1
utf8
EOF
LC_ALL="is_IS.UTF-8" git -c grep.patternType=fixed log
--encoding=ISO-8859-1 --format=%s --grep="_" >actual &&
test_cmp expect actual
fatal: command line, '_': illegal byte sequence
This was added in 4e2443b1813 with this note in the commit message:
| It's possible that this
| test breaks the "basic" and "extended" backends on some systems that
| are more anal than glibc about the encoding of locale issues with
| POSIX functions that I can remember, but PCRE is more careful about
| the validation.
I've CC'd Ævar Arnfjörð Bjarmason for advice on this.
next prev parent reply other threads:[~2019-11-26 17:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 20:37 [PATCH] ci: add Cirrus-CI config for FreeBSD CI Ed Maste
2019-11-26 0:44 ` brian m. carlson
2019-11-26 13:31 ` Ed Maste [this message]
2019-11-27 14:01 ` Ed Maste
2019-11-27 15:17 ` Ed Maste
2019-12-20 2:11 ` [PATCH v2] CI: add FreeBSD CI support via Cirrus-CI Ed Maste
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPyFy2A8x99fa3ti1E9Fqkcpw8RQBn5AJaL+u5g=e0qeMeyf2A@mail.gmail.com' \
--to=emaste@freebsd.org \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).