git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Gennady Kupava <gennady.kupava@gmail.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: git <git@vger.kernel.org>, Gennady Kupava <gkupava@bloomberg.net>
Subject: Re: [PATCH 2/2] Reduce performance cost of the trace if trace category is disabled
Date: Sun, 19 Nov 2017 13:18:31 +0000	[thread overview]
Message-ID: <CAPu-DQqO5gfr3H_vHu3JBeJrkCmh6qQ=vs=GOkLKjtE9=tDgcg@mail.gmail.com> (raw)
In-Reply-To: <d9076fef-c90c-63f2-5e0e-37293810e3d9@kdbg.org>

Right, this trace is actually not used anywhere, so only check was
compilation. Will fix that.

On 19 November 2017 at 08:27, Johannes Sixt <j6t@kdbg.org> wrote:
> Am 19.11.2017 um 01:42 schrieb gennady.kupava@gmail.com:
>>
>> +#define trace_printf_key(key, ...)
>> \
>> +       do {
>> \
>> +               if (trace_pass_fl(key))
>> \
>> +                       trace_printf_key_fl(TRACE_CONTEXT, __LINE__, key,
>> \
>> +                                           __VA_ARGS__);
>> \
>> +       } while(0)
>> +
>> +#define trace_printf(...) trace_printf_key(&trace_default_key,
>> __VA_ARGS__);
>> +
>> +#define trace_argv_printf(argv, ...)
>> \
>> +       do {
>> \
>> +               if (trace_pass_fl(&trace_default_key))
>> \
>> +                      trace_argv_printf_fl(TRACE_CONTEXT, __LINE__,
>> \
>> +                                           argv, __VA_ARGS__);
>> \
>> +       } while(0)
>> +
>> +#define trace_strbuf(key, data)
>> \
>> +       do {
>> \
>> +               if (trace_pass_fl(key))
>> \
>> +                       trace_strbuf_fl(TRACE_CONTEXT, __LINE__, key,
>> data);\
>> +       } while(0)
>> +
>> +#define trace_performance(nanos, ...)
>> \
>> +       do {
>> \
>> +               if (trace_pass_fl(key))
>> \
>
>
> The token "key" here looks suspicious. Did you mean &trace_perf_key?
>
>> +                       trace_performance_fl(TRACE_CONTEXT, __LINE__,
>> nanos,\
>> +                                            __VA_ARGS__);
>> \
>> +       } while(0)
>> +
>> +#define trace_performance_since(start, ...)
>> \
>> +       do {
>> \
>> +               if (trace_pass_fl(&trace_perf_key))
>> \
>> +                       trace_performance_fl(TRACE_CONTEXT, __LINE__,
>> \
>> +                                            getnanotime() - (start),
>> \
>> +                                            __VA_ARGS__);
>> \
>> +       } while(0)
>>     /* backend functions, use non-*fl macros instead */
>>   __attribute__((format (printf, 4, 5)))
>
>
> -- Hannes

  reply	other threads:[~2017-11-19 13:24 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-11 19:28 [PATCH] Reduce performance penalty for turned off traces gennady.kupava
2017-11-12 14:17 ` Jeff King
2017-11-12 23:24   ` Gennady Kupava
2017-11-17 22:12     ` Jeff King
2017-11-15 19:14   ` Stefan Beller
2017-11-17 22:16     ` Jeff King
2017-11-19  0:42       ` [PATCH 1/2] Simplify tracing code by removing trace key normalization concept gennady.kupava
2017-11-19  0:42         ` [PATCH 2/2] Reduce performance cost of the trace if trace category is disabled gennady.kupava
2017-11-19  8:27           ` Johannes Sixt
2017-11-19 13:18             ` Gennady Kupava [this message]
2017-11-19  2:19         ` [PATCH 1/2] Simplify tracing code by removing trace key normalization concept Junio C Hamano
2017-11-19 13:16           ` Gennady Kupava
2017-11-20  0:24             ` Junio C Hamano
2017-11-20  4:59               ` Junio C Hamano
2017-11-26 20:11                 ` [PATCH 1/2] trace: remove trace key normalization gennady.kupava
2017-11-26 20:11                   ` [PATCH 2/2] trace: improve performance while category is disabled gennady.kupava
2017-11-27  1:21                     ` Junio C Hamano
2017-11-27  1:32                       ` Junio C Hamano
2017-11-27  3:25                         ` Junio C Hamano
2017-11-27 10:12                           ` Gennady Kupava

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPu-DQqO5gfr3H_vHu3JBeJrkCmh6qQ=vs=GOkLKjtE9=tDgcg@mail.gmail.com' \
    --to=gennady.kupava@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gkupava@bloomberg.net \
    --cc=j6t@kdbg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).