From: Gennady Kupava <gennady.kupava@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git <git@vger.kernel.org>, Gennady Kupava <gkupava@bloomberg.net>
Subject: Re: [PATCH 2/2] trace: improve performance while category is disabled
Date: Mon, 27 Nov 2017 10:12:16 +0000 [thread overview]
Message-ID: <CAPu-DQpKRvU05pgfFpdguAfMKJnHpshsajivTCtNa56GtToUtg@mail.gmail.com> (raw)
In-Reply-To: <xmqq8tesflne.fsf@gitster.mtv.corp.google.com>
> Spotted yet another. This function in a header file, that is
included by many source files, must be made "static inline" (which I
already did as without the fix I couldn't get 'pu' to compile).
Thanks, missed that, seems my compiler inlined all calls and I didn't
notice the problem.
On 27 November 2017 at 03:25, Junio C Hamano <gitster@pobox.com> wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Just in case others notice style and whitespace issues, I've applied
>> the following to fix them, so there is no need to reroll only to fix
>> these.
>> ...
>> -inline int trace_pass_fl(struct trace_key *key) {
>> +inline int trace_pass_fl(struct trace_key *key)
>> +{
>> return key->fd || !key->initialized;
>> }
>
> Spotted yet another. This function in a header file, that is
> included by many source files, must be made "static inline" (which I
> already did as without the fix I couldn't get 'pu' to compile).
>
>
>
prev parent reply other threads:[~2017-11-27 10:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-11 19:28 [PATCH] Reduce performance penalty for turned off traces gennady.kupava
2017-11-12 14:17 ` Jeff King
2017-11-12 23:24 ` Gennady Kupava
2017-11-17 22:12 ` Jeff King
2017-11-15 19:14 ` Stefan Beller
2017-11-17 22:16 ` Jeff King
2017-11-19 0:42 ` [PATCH 1/2] Simplify tracing code by removing trace key normalization concept gennady.kupava
2017-11-19 0:42 ` [PATCH 2/2] Reduce performance cost of the trace if trace category is disabled gennady.kupava
2017-11-19 8:27 ` Johannes Sixt
2017-11-19 13:18 ` Gennady Kupava
2017-11-19 2:19 ` [PATCH 1/2] Simplify tracing code by removing trace key normalization concept Junio C Hamano
2017-11-19 13:16 ` Gennady Kupava
2017-11-20 0:24 ` Junio C Hamano
2017-11-20 4:59 ` Junio C Hamano
2017-11-26 20:11 ` [PATCH 1/2] trace: remove trace key normalization gennady.kupava
2017-11-26 20:11 ` [PATCH 2/2] trace: improve performance while category is disabled gennady.kupava
2017-11-27 1:21 ` Junio C Hamano
2017-11-27 1:32 ` Junio C Hamano
2017-11-27 3:25 ` Junio C Hamano
2017-11-27 10:12 ` Gennady Kupava [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPu-DQpKRvU05pgfFpdguAfMKJnHpshsajivTCtNa56GtToUtg@mail.gmail.com \
--to=gennady.kupava@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=gkupava@bloomberg.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).