From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 5F9AF1F4B4 for ; Fri, 25 Sep 2020 17:34:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727874AbgIYRd2 (ORCPT ); Fri, 25 Sep 2020 13:33:28 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:40087 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726368AbgIYRd2 (ORCPT ); Fri, 25 Sep 2020 13:33:28 -0400 Received: by mail-ed1-f68.google.com with SMTP id t16so3299777edw.7 for ; Fri, 25 Sep 2020 10:33:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Lt3WCrhP3RYN6DiPR/ngTU0ItzK2HVVSmS1+0lT0MAQ=; b=bKKv8+H/hyUTlJW8xvwUIsBdtYeDuiRF09sy+Q9i9euPfq0MXp1kjbLPmCLArjS/0Q 1d+35AA5owmsdlNrUVhcB4ZLzX7V13HL2Z6cqfnTJ8ukcJHbZm16uMuaWFwKuIOAUmSQ 6RNyf5xrzstBotqcU/Z0Uee8bdNyBJm4Rbyldl1AEMFu4HaHwy7I1qeTqOgDnaaSBdyC vnoC5N9eVlEVVg2fe/MhxBog+PiUMWUdRnXqsaYdtrSzGjqDz/1Je9oo0VlPvwyBy92h zwBHVtC/FL7NANkilNZ+Mk8HRYrS4Bxa7XRJUFKa+yXO4e42XFLC8Md6f54kUYN5sDaV hjgA== X-Gm-Message-State: AOAM532WkPVDQ379v47H7ZAG2JjyJ3CCWAYtYD1pz5HllwniKdND03pf 9yU5FKIuFpTJKrqNzHis136RM4osn7OsERBBCdg= X-Google-Smtp-Source: ABdhPJyIcrTIBr0+bjinkZbpoWEEOkZl5kG4XclR1ZitIwSoB4XZKacb8f4Jqb9Rtol2+NfN30JACm8QCb6KNCol9Mg= X-Received: by 2002:a50:cdd1:: with SMTP id h17mr2566193edj.94.1601055206700; Fri, 25 Sep 2020 10:33:26 -0700 (PDT) MIME-Version: 1.0 References: <20200925170256.11490-1-shubhunic@gmail.com> In-Reply-To: <20200925170256.11490-1-shubhunic@gmail.com> From: Eric Sunshine Date: Fri, 25 Sep 2020 13:33:15 -0400 Message-ID: Subject: Re: [PATCH 00/11] Modernizing the t7001 test script To: shubham verma Cc: Git List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Sep 25, 2020 at 1:03 PM shubham verma wrote: > In this patch series modernize the t7001 test script by changing the > style of its tests from an old one to the modern one and by cleaning > up the test script. Thanks for tackling this task. I presume it was prompted by [1] or [2], as this series covers many of the items mentioned in [1]. Overall, the series looks good. I'll leave comments in a few of the individual patches. [1]: https://lore.kernel.org/git/CAPig+cQpUu2UO-+jWn1nTaDykWnxwuEitzVB7PnW2SS_b7V8Hg@mail.gmail.com/ [2]: https://git.github.io/rev_news/2020/08/27/edition-66/