git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: Derrick Stolee <stolee@gmail.com>,
	"git@vger.kernel.org" <git@vger.kernel.org>,
	Jeff King <peff@peff.net>, Junio C Hamano <gitster@pobox.com>
Subject: Re: Git Test Coverage Report (Mon. Dec 9)
Date: Mon, 9 Dec 2019 12:19:59 -0500	[thread overview]
Message-ID: <CAPig+cTrAsn64S0Qm7PdJVFhsquVA3+ugwngLpo1S4yUjMcrGA@mail.gmail.com> (raw)
In-Reply-To: <e47b77b4-7b7a-3d59-9e24-934528c5e297@web.de>

On Mon, Dec 9, 2019 at 12:11 PM René Scharfe <l.s.r@web.de> wrote:
> Am 09.12.19 um 16:36 schrieb Derrick Stolee:
> > René Scharfe  0bb313a5 xdiff: unignore changes in function context
> > xdiff/xemit.c
> > 0bb313a5 223)        xchp->i1 + xchp->chg1 <= s1 &&
> > 0bb313a5 224)        xchp->i2 + xchp->chg2 <= s2)
> > 0bb313a5 225) xchp = xchp->next;
>
> Hmm, line 223 *is* exercised by t4015.85.

This, along with Dscho's[1] review of an earlier coverage report,
makes one wonder if there is some off-by-one error in the reporting
logic, such that it is reporting the wrong lines as not covered.

Footnotes:

[1]: https://lore.kernel.org/git/nycvar.QRO.7.76.6.1911262116100.31080@tvgsbejvaqbjf.bet/
which, among other seeming anomalies pointed out by Dscho, showed a
closing brace '}' not covered by a test:

    > Johannes Schindelin 867bc1d2 rebase-merges: ...
    > sequencer.c
    > 867bc1d2 4539) }

    Not sure why this closing parenthesis isn't covered :-D

  reply	other threads:[~2019-12-09 17:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-09 15:36 Git Test Coverage Report (Mon. Dec 9) Derrick Stolee
2019-12-09 17:10 ` René Scharfe
2019-12-09 17:19   ` Eric Sunshine [this message]
2019-12-09 17:44     ` Derrick Stolee
2019-12-09 18:10       ` René Scharfe
2019-12-09 18:23         ` Derrick Stolee
2019-12-09 20:17           ` Derrick Stolee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPig+cTrAsn64S0Qm7PdJVFhsquVA3+ugwngLpo1S4yUjMcrGA@mail.gmail.com \
    --to=sunshine@sunshineco.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=l.s.r@web.de \
    --cc=peff@peff.net \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).