git@vger.kernel.org list mirror (unofficial, one of many)
 help / color / mirror / Atom feed
* [PATCH] sequencer: mark a file-local symbol as static
@ 2019-03-12  2:53 Ramsay Jones
  2019-03-12  2:58 ` Eric Sunshine
  0 siblings, 1 reply; 2+ messages in thread
From: Ramsay Jones @ 2019-03-12  2:53 UTC (permalink / raw)
  To: liu.denton; +Cc: Junio C Hamano, GIT Mailing-list


Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---

Hi Denton,

If you need to re-roll your 'dl/merge-cleanup-scissors-fix' branch,
could you please squash this into the relevant patch (commit 9bcdf520cb
("sequencer.c: define get_config_from_cleanup", 2019-03-10)).

I note also, that the get_config_from_cleanup() function is not
called outside of sequencer.c, so that this function could also
be marked static (and remove the extern declaration from the
header file) if there are no plans for future callers.

Thanks!

ATB,
Ramsay Jones


 sequencer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sequencer.c b/sequencer.c
index 19d1279fa8..833017eb2d 100644
--- a/sequencer.c
+++ b/sequencer.c
@@ -166,7 +166,7 @@ struct cleanup_config_mapping {
 };
 
 /* note that we assume that cleanup_config_mapping[0] contains the default settings */
-struct cleanup_config_mapping cleanup_config_mappings[] = {
+static struct cleanup_config_mapping cleanup_config_mappings[] = {
 	{ "default", COMMIT_MSG_CLEANUP_ALL, COMMIT_MSG_CLEANUP_SPACE },
 	{ "verbatim", COMMIT_MSG_CLEANUP_NONE, COMMIT_MSG_CLEANUP_NONE },
 	{ "whitespace", COMMIT_MSG_CLEANUP_SPACE, COMMIT_MSG_CLEANUP_SPACE },
-- 
2.21.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] sequencer: mark a file-local symbol as static
  2019-03-12  2:53 [PATCH] sequencer: mark a file-local symbol as static Ramsay Jones
@ 2019-03-12  2:58 ` Eric Sunshine
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Sunshine @ 2019-03-12  2:58 UTC (permalink / raw)
  To: Ramsay Jones; +Cc: Denton Liu, Junio C Hamano, GIT Mailing-list

On Mon, Mar 11, 2019 at 10:53 PM Ramsay Jones
<ramsay@ramsayjones.plus.com> wrote:
> If you need to re-roll your 'dl/merge-cleanup-scissors-fix' branch,
> could you please squash this into the relevant patch (commit 9bcdf520cb
> ("sequencer.c: define get_config_from_cleanup", 2019-03-10)).
>
>  /* note that we assume that cleanup_config_mapping[0] contains the default settings */
> -struct cleanup_config_mapping cleanup_config_mappings[] = {
> +static struct cleanup_config_mapping cleanup_config_mappings[] = {

This was also suggested during review[1].

[1]: http://public-inbox.org/git/CAPig+cQGvmi-237s1Leb1NpOMA0683PkCG4HBCKn_+x5YDHnCQ@mail.gmail.com/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-03-12  2:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-12  2:53 [PATCH] sequencer: mark a file-local symbol as static Ramsay Jones
2019-03-12  2:58 ` Eric Sunshine

git@vger.kernel.org list mirror (unofficial, one of many)

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://public-inbox.org/git
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 git git/ https://public-inbox.org/git \
		git@vger.kernel.org
	public-inbox-index git

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.public-inbox.org/inbox.comp.version-control.git
	nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git
	nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git
	nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git
	nntp://news.gmane.io/gmane.comp.version-control.git
 note: .onion URLs require Tor: https://www.torproject.org/

code repositories for the project(s) associated with this inbox:

	https://80x24.org/mirrors/git.git

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git