From: Eric Sunshine <sunshine@sunshineco.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Denton Liu <liu.denton@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] sequencer: mark a file-local symbol as static
Date: Mon, 11 Mar 2019 22:58:32 -0400 [thread overview]
Message-ID: <CAPig+cTqdeVXyYZarGOb+AiLOERO0HpK+ykYgrAddyFzPG0+Mg@mail.gmail.com> (raw)
In-Reply-To: <d5d47b6b-25d9-a649-e13d-76e98e07ed51@ramsayjones.plus.com>
On Mon, Mar 11, 2019 at 10:53 PM Ramsay Jones
<ramsay@ramsayjones.plus.com> wrote:
> If you need to re-roll your 'dl/merge-cleanup-scissors-fix' branch,
> could you please squash this into the relevant patch (commit 9bcdf520cb
> ("sequencer.c: define get_config_from_cleanup", 2019-03-10)).
>
> /* note that we assume that cleanup_config_mapping[0] contains the default settings */
> -struct cleanup_config_mapping cleanup_config_mappings[] = {
> +static struct cleanup_config_mapping cleanup_config_mappings[] = {
This was also suggested during review[1].
[1]: http://public-inbox.org/git/CAPig+cQGvmi-237s1Leb1NpOMA0683PkCG4HBCKn_+x5YDHnCQ@mail.gmail.com/
prev parent reply other threads:[~2019-03-12 2:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 2:53 [PATCH] sequencer: mark a file-local symbol as static Ramsay Jones
2019-03-12 2:58 ` Eric Sunshine [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cTqdeVXyYZarGOb+AiLOERO0HpK+ykYgrAddyFzPG0+Mg@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=liu.denton@gmail.com \
--cc=ramsay@ramsayjones.plus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).