From: Eric Sunshine <sunshine@sunshineco.com>
To: Dragan Simic <dsimic@manjaro.org>
Cc: git@vger.kernel.org, gitster@pobox.com, jn.avila@free.fr
Subject: Re: [PATCH v3 0/3] Assorted improvements salvaged from an earlier series
Date: Fri, 5 Apr 2024 21:49:00 -0400 [thread overview]
Message-ID: <CAPig+cToJgRn-ao9c9wXf7g99_TL3aRfwEasA9U3e4qNC3cVMg@mail.gmail.com> (raw)
In-Reply-To: <f5c2c3af9813d56adf85393f0e8fde0e@manjaro.org>
On Fri, Apr 5, 2024 at 8:52 PM Dragan Simic <dsimic@manjaro.org> wrote:
> On 2024-03-25 21:54, Dragan Simic wrote:
> > On 2024-03-25 21:49, Eric Sunshine wrote:
> >> The range-diff is particularly valuable exactly for this case (new
> >> versions of old patches) since it is a "diff" between the old patches
> >> and the new patches. Thus, it provides reviewers with a precise
> >> summary of what changed between, say, v2 and v3 of a series, and
> >> manifests as a concrete representation of what your prose explanation
> >> describes.
> >
> > I see, and I do understand the purpose of range-diffs: they make
> > reviewing new patch versions significantly easier, by relieving the
> > reviewers from the need to track down what has been changed in the
> > current patch version.
>
> As a note, I kept my promise :) and have started providing range-diffs
> in patch submissions. [1]
Glad to hear. Thanks.
prev parent reply other threads:[~2024-04-06 1:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 20:34 [PATCH v3 0/3] Assorted improvements salvaged from an earlier series Dragan Simic
2024-03-25 20:34 ` [PATCH v3 1/3] grep: perform some minor code and comment cleanups Dragan Simic
2024-03-25 20:34 ` [PATCH v3 2/3] grep docs: describe --recurse-submodules further and improve formatting a bit Dragan Simic
2024-03-25 20:34 ` [PATCH v3 3/3] grep docs: describe --no-index " Dragan Simic
2024-03-25 20:39 ` [PATCH v3 0/3] Assorted improvements salvaged from an earlier series Eric Sunshine
2024-03-25 20:41 ` Dragan Simic
2024-03-25 20:49 ` Eric Sunshine
2024-03-25 20:54 ` Dragan Simic
2024-04-06 0:52 ` Dragan Simic
2024-04-06 1:49 ` Eric Sunshine [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cToJgRn-ao9c9wXf7g99_TL3aRfwEasA9U3e4qNC3cVMg@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=dsimic@manjaro.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jn.avila@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).