git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Sarah Julia Kriesch <sarah.kriesch@opensuse.org>,
	Git List <git@vger.kernel.org>
Subject: Re: git can not be built for s390x since update to git-2.38.0
Date: Tue, 22 Nov 2022 11:16:01 -0500	[thread overview]
Message-ID: <CAPig+cTniT+_7MxMm3Kc2C_oEtQGg-WA3870baL8990Av6HmJQ@mail.gmail.com> (raw)
In-Reply-To: <221122.86zgcj9hmc.gmgdl@evledraar.gmail.com>

On Tue, Nov 22, 2022 at 9:41 AM Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
> On Mon, Nov 21 2022, Eric Sunshine wrote:
> > The empty "chainlinttmp/tests" file also sounds suspicious. If you
> > haven't already done so, I would recommend following the advice in [1]
> > and running each command individually which Makefile would have run;
> > this might allow you to isolate the problematic command or shell
> > construct if such exists.
>
> I can also reproduce this on gcc202. It's the same issue with ending up
> with an empty "tests" file.

Were you able to determine why the "tests" file is empty? The creation
loop is simple enough:

    for i in $(CHAINLINTTESTS); do \
        echo "test_expect_success '$$i' '" && \
        sed -e '/^# LINT: /d' chainlint/$$i.test && \
        echo "'"; \
    done >'$(CHAINLINTTMP_SQ)'/tests && \

and the file is never changed after that (or shouldn't be).

>         avar@gcc202:/run/user/1632/git/t$ uname -a
>         Linux gcc202 6.0.0-4-sparc64-smp #1 SMP Debian 6.0.8-1 (2022-11-11) sparc64 GNU/Linux
>         avar@gcc202:/run/user/1632/git/t$ lsb_release -a
>         No LSB modules are available.
>         Distributor ID: Debian
>         Description:    Debian GNU/Linux bookworm/sid
>         Release:        n/a
>         Codename:       bookworm

This is one of the compile-machines to which you have access?

> The change at the tip of
> https://lore.kernel.org/git/221122.86cz9fbyln.gmgdl@evledraar.gmail.com/
> fixes it for me, i.e. getting rid of the perl threads stuff...

I'm confused. How does a change to chainlint.pl -- which only reads
the "tests" file -- fix the empty "tests" file?

> That box is built with "useithreads=define", so it's not that it doesn't
> support threading in general.

  reply	other threads:[~2022-11-22 16:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4657a19c-89c3-2237-9e6b-db897a492072@opensuse.org>
2022-11-21  5:12 ` git can not be built for s390x since update to git-2.38.0 Eric Sunshine
2022-11-22 14:35   ` Ævar Arnfjörð Bjarmason
2022-11-22 16:16     ` Eric Sunshine [this message]
2022-11-22 22:01       ` Ævar Arnfjörð Bjarmason
2022-11-22 22:20         ` Eric Sunshine
2022-11-06 18:32 Sarah Julia Kriesch
2022-11-06 19:15 ` Sarah Julia Kriesch
2022-11-06 20:42   ` Eric Sunshine
2022-11-07  0:42   ` Todd Zullinger
2022-11-22 18:21   ` Eric Sunshine
2022-11-07  0:41 ` Todd Zullinger
  -- strict thread matches above, loose matches on Subject: below --
2022-11-01 18:04 Sarah Julia Kriesch
2022-11-01 19:05 ` Martin Ågren
2022-11-01 19:38   ` Taylor Blau
2022-11-01 19:41   ` Martin Ågren
2022-11-01 22:03     ` Eric Sunshine
2022-11-02 18:49 ` Todd Zullinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPig+cTniT+_7MxMm3Kc2C_oEtQGg-WA3870baL8990Av6HmJQ@mail.gmail.com \
    --to=sunshine@sunshineco.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=sarah.kriesch@opensuse.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).