From: Eric Sunshine <sunshine@sunshineco.com>
To: Alexander Shopov <ash@kambanaria.org>
Cc: "Git List" <git@vger.kernel.org>,
"Junio C Hamano" <gitster@pobox.com>,
"Martin Ågren" <martin.agren@gmail.com>,
"Brandon Williams" <bmwill@google.com>,
"Jeff King" <peff@peff.net>,
"brian m. carlson" <sandals@crustytoothpaste.net>,
"Jiang Xin" <worldhello.net@gmail.com>
Subject: Re: [PATCH 1/1] Mark messages for translations
Date: Mon, 15 Jan 2018 04:58:29 -0500 [thread overview]
Message-ID: <CAPig+cTm=bNqncS63DmN6Qi7GGkXcPv-wnKfNe=btgSM9YTPYg@mail.gmail.com> (raw)
In-Reply-To: <20180115054419.4112-2-ash@kambanaria.org>
On Mon, Jan 15, 2018 at 12:44 AM, Alexander Shopov <ash@kambanaria.org> wrote:
> Reuse already translated messages if possible
> Do not translate messages aimed at developers of git
A couple comments beyond those from Hannes...
> Signed-off-by: Alexander Shopov <ash@kambanaria.org>
> ---
> diff --git a/git.c b/git.c
> @@ -5,11 +5,11 @@
> const char git_usage_string[] =
> + N_("git [--version] [--help] [-C <path>] [-c name=value]\n"
Since you're touching this, perhaps take the opportunity to fix `-c
name=value` to say `-c <name>=<value>`?
> + " [--exec-path[=<path>]] [--html-path] [--man-path] [--info-path]\n"
> + " [-p | --paginate | --no-pager] [--no-replace-objects] [--bare]\n"
> + " [--git-dir=<path>] [--work-tree=<path>] [--namespace=<name>]\n"
> + " <command> [<args>]");
> diff --git a/setup.c b/setup.c
> @@ -525,19 +525,19 @@ void read_gitfile_error_die(int error_code, const char *path, const char *dir)
> case READ_GITFILE_ERR_NOT_A_REPO:
> - die("Not a git repository: %s", dir);
> + die(_("Not a git repository: %s"), dir);
> default:
> - die("BUG: unknown error code");
> + die(_("BUG: unknown error code"));
This last one is aimed at developers (indeed, "BUG" message should
never been seen by end-users). I'd leave it untranslated.
> }
> }
next prev parent reply other threads:[~2018-01-15 9:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 5:44 [PATCH 0/1] Marked end user messages for translation Alexander Shopov
2018-01-15 5:44 ` [PATCH 1/1] Mark messages for translations Alexander Shopov
2018-01-15 7:33 ` Johannes Sixt
[not found] ` <CAP6f5Mnn+pRdL6ihgwcqsTwyGy+EQfBbgPxkFmGLcWL-hJx-8g@mail.gmail.com>
[not found] ` <CAP6f5MnaMiqEMbGW_xj6X495jF=txpzeq+DEHOkz7VCg2D6D9w@mail.gmail.com>
2018-01-15 9:16 ` Alexander Shopov
2018-01-15 9:58 ` Eric Sunshine [this message]
2018-01-15 10:21 ` Duy Nguyen
2018-02-06 6:15 ` [PATCH 0/1] " Alexander Shopov
2018-02-06 6:15 ` [PATCH 1/1] " Alexander Shopov
2018-02-06 7:32 ` Eric Sunshine
2018-02-06 7:38 ` Jeff King
2018-02-09 7:44 ` [PATCH 0/1] " Alexander Shopov
2018-02-09 7:44 ` [PATCH 1/1] " Alexander Shopov
2018-02-09 18:20 ` Junio C Hamano
2018-02-09 19:15 ` Junio C Hamano
2018-02-09 19:30 ` Jeff King
2018-02-10 11:31 ` [PATCH] t0002: simplify error checking Jeff King
2018-02-12 15:03 ` [PATCH 1/1] Mark messages for translations Alexander Shopov
2018-02-12 15:15 ` Jeff King
2018-02-13 13:19 ` [PATCH 0/1] Mark messages for translation Alexander Shopov
2018-02-13 13:19 ` [PATCH 1/1] Mark messages for translations Alexander Shopov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cTm=bNqncS63DmN6Qi7GGkXcPv-wnKfNe=btgSM9YTPYg@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=ash@kambanaria.org \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=martin.agren@gmail.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
--cc=worldhello.net@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).