From: Eric Sunshine <sunshine@sunshineco.com>
To: Anthony Sottile <asottile@umich.edu>
Cc: "Git List" <git@vger.kernel.org>, "Torsten Bögershausen" <tboegi@web.de>
Subject: Re: [PATCH] config.c: fix regression for core.safecrlf false
Date: Tue, 12 Jun 2018 00:34:03 -0400 [thread overview]
Message-ID: <CAPig+cTgJbwatnZ+9eAvjQ1Mn7dszWr9Tgh5GTJNAH-jNjV=Cg@mail.gmail.com> (raw)
In-Reply-To: <CA+dzEBk8H_=a9k1DaFUK=JJBhd17bhS3+ngSUBcBV+7hD-RFMw@mail.gmail.com>
[cc:+torsten]
On Mon, Jun 11, 2018 at 9:46 PM, Anthony Sottile <asottile@umich.edu> wrote:
> On Wed, Jun 6, 2018 at 10:22 AM, Eric Sunshine <sunshine@sunshineco.com> wrote:
>> Thanks for pointing that out. In that case, it's following existing
>> practice, thus certainly not worth a re-roll.
>
> Anything else for me to do here? (sorry! not super familiar with the process)
I don't think so. Nothing in the review warranted a re-roll, and
(importantly) Torsten gave his Acked-by:, so the next step is to wait
for Junio to pick up the patch. He's been offline for a bit, so it
might take a some time for him to catch up since the list has been
plenty busy in his absence.
It's a good idea to check the "What's Cooking" summaries Junio sends
to the mailing list once in a while to check the progress of your
patch. If you don't see it show up in the summary within a couple
weeks or so, it wouldn't hurt to ping again (as you did here).
next prev parent reply other threads:[~2018-06-12 4:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-04 20:17 [PATCH] config.c: fix regression for core.safecrlf false Anthony Sottile
2018-06-06 15:53 ` Torsten Bögershausen
2018-06-06 17:15 ` Eric Sunshine
2018-06-06 17:17 ` Eric Sunshine
2018-06-06 17:18 ` Anthony Sottile
2018-06-06 17:22 ` Eric Sunshine
2018-06-12 1:46 ` Anthony Sottile
2018-06-12 4:34 ` Eric Sunshine [this message]
2018-06-13 1:19 ` Torsten Bögershausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cTgJbwatnZ+9eAvjQ1Mn7dszWr9Tgh5GTJNAH-jNjV=Cg@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=asottile@umich.edu \
--cc=git@vger.kernel.org \
--cc=tboegi@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).