From: Eric Sunshine <sunshine@sunshineco.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Christian Couder <christian.couder@gmail.com>,
git <git@vger.kernel.org>,
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
Thomas Ferris Nicolaisen <tfnico@gmail.com>,
Nicola Paolucci <npaolucci@atlassian.com>
Subject: Re: Draft of Git Rev News edition 5
Date: Mon, 6 Jul 2015 13:24:40 -0400 [thread overview]
Message-ID: <CAPig+cTfkDqSDRqDjA=CNkT1c7Fo0zaLiwi2bAbCLZxPHi5=Bg@mail.gmail.com> (raw)
In-Reply-To: <xmqqa8v92qdf.fsf@gitster.dls.corp.google.com>
On Mon, Jul 6, 2015 at 12:38 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Eric Sunshine <sunshine@sunshineco.com> writes:
>> I'm not familiar with the criteria for deciding what merits mention
>> in the newsletter. Is the recent introduction of git-worktree and the
>> attendant relocation of "add" and "prune" functionality worthy? If
>> so, perhaps the following write-up would be suitable?
>
> One issue I had with this text was that it was not immediately clear
> what the end-game UI of the feature was. Is "checkout --to" they
> way the user is expected to trigger this? It appears in the very
> early part of the multi-paragraph description and I suspect that the
> majority of the users would think that way, not with "worktree add"
> that appears a lot later.
I had the same concern when proof-reading, but wasn't sure if the
concern was warranted. Since you reacted to the text in the same way,
I'd say the concern was justified.
How about this instead: prefixing with "As originally implemented",
with a couple s/is/was/ thrown in...
As originally implemented, creation of linked-worktrees was
accomplished via `git checkout --to <path> <branch>`, and cleanup
of leftover administrative files, after `<path>` is deleted, was
done with `git prune --worktrees`. However, a recent unrelated
change to `git prune` led to a discussion that concluded that
worktree-related maintenance functionality didn't belong in `git
prune`.
Is that sufficient to clue in the reader that "checkout --to" is not
final form, or should we mention "worktree add" and "worktree prune"
upfront?
next prev parent reply other threads:[~2015-07-06 17:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-05 11:13 Draft of Git Rev News edition 5 Christian Couder
2015-07-05 19:11 ` Eric Sunshine
2015-07-05 21:13 ` Christian Couder
2015-07-05 22:01 ` Eric Sunshine
2015-07-05 22:35 ` Thomas Ferris Nicolaisen
2015-07-05 23:12 ` Eric Sunshine
2015-07-08 7:22 ` Michael J Gruber
2015-07-08 7:43 ` Junio C Hamano
2015-07-08 10:29 ` Christian Couder
2015-07-08 13:02 ` Johannes Schindelin
2015-07-08 17:36 ` Junio C Hamano
2015-07-06 16:38 ` Junio C Hamano
2015-07-06 17:24 ` Eric Sunshine [this message]
2015-07-06 17:54 ` Junio C Hamano
2015-07-06 19:39 ` Eric Sunshine
2015-07-06 19:59 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cTfkDqSDRqDjA=CNkT1c7Fo0zaLiwi2bAbCLZxPHi5=Bg@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=npaolucci@atlassian.com \
--cc=tfnico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).