From: Eric Sunshine <sunshine@sunshineco.com>
To: Stefan Beller <sbeller@google.com>
Cc: "Git List" <git@vger.kernel.org>,
"Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
"Junio C Hamano" <gitster@pobox.com>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Subject: Re: [PATCH] builtin/mv: Get rid of the last caller of get_pathspec
Date: Mon, 3 Aug 2015 18:48:16 -0400 [thread overview]
Message-ID: <CAPig+cT_YB=HY9dBo5eRNu4qvCqCXRwwXgpxCA8YjxagP+sHfA@mail.gmail.com> (raw)
In-Reply-To: <1438624382-31248-1-git-send-email-sbeller@google.com>
On Mon, Aug 3, 2015 at 1:53 PM, Stefan Beller <sbeller@google.com> wrote:
> `get_pathspec` is deprecated and builtin/mv is its last caller, so getting
> rid of `get_pathspec` is rather easy. By getting rid of `get_pathspec`,
> the documentation such as 'technical/api-setup.txt' becomes easier to read
> as the reader doesn't need to bear with the additional fact that
> `get_pathspec` is deprecated.
>
> The code in 'builtin/mv' still requires some work to make it less ugly.
Perhaps split this into two patches? One to free git-mv of
get_pathspec() dependence, and the second to actually retire
get_pathspec().
> Signed-off-by: Stefan Beller <sbeller@google.com>
next prev parent reply other threads:[~2015-08-03 22:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 17:53 [PATCH] builtin/mv: Get rid of the last caller of get_pathspec Stefan Beller
2015-08-03 22:48 ` Eric Sunshine [this message]
2015-08-06 18:27 ` [PATCH 0/2] Remove get_pathspec finally Stefan Beller
2015-08-06 18:27 ` [PATCH 1/2] builtin/mv: remove get_pathspec() Stefan Beller
2015-08-06 18:46 ` Eric Sunshine
2015-08-06 18:58 ` Stefan Beller
2015-08-06 20:18 ` Eric Sunshine
2015-08-06 20:59 ` Stefan Beller
2015-08-06 18:27 ` [PATCH 2/2] pathspec: remove deprecated get_pathspec Stefan Beller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cT_YB=HY9dBo5eRNu4qvCqCXRwwXgpxCA8YjxagP+sHfA@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).