From: Eric Sunshine <sunshine@sunshineco.com>
To: "Antoine Beaupré" <anarcat@debian.org>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH 5/7] remote-mediawiki: support fetching from (Main) namespace
Date: Wed, 1 Nov 2017 15:56:51 -0400 [thread overview]
Message-ID: <CAPig+cTX1kBCk-phodTanU1dmwjM_2TNevKyGvdCWonqhEU5Dg@mail.gmail.com> (raw)
In-Reply-To: <20171030025142.19421-6-anarcat@debian.org>
On Sun, Oct 29, 2017 at 10:51 PM, Antoine Beaupré <anarcat@debian.org> wrote:
> When we specify a list of namespaces to fetch from, by default the MW
> API will not fetch from the default namespace, refered to as "(Main)"
> in the documentation:
>
> https://www.mediawiki.org/wiki/Manual:Namespace#Built-in_namespaces
>
> I haven't found a way to address that "(Main)" namespace when getting
> the namespace ids: indeed, when listing namespaces, there is no
> "canonical" field for the main namespace, although there is a "*"
> field that is set to "" (empty). So in theory, we could specify the
> empty namespace to get the main namespace, but that would make
> specifying namespaces harder for the user: we would need to teach
> users about the "empty" default namespace. It would also make the code
> more complicated: we'd need to parse quotes in the configuration.
>
> So we simply override the query here and allow the user to specify
> "(Main)" since that is the publicly documented name.
Thanks, this explanation makes the patch a lot clearer. More below...
> Signed-off-by: Antoine Beaupré <anarcat@debian.org>
> ---
> diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl b/contrib/mw-to-git/git-remote-mediawiki.perl
> @@ -264,9 +264,14 @@ sub get_mw_tracked_categories {
> sub get_mw_tracked_namespaces {
> my $pages = shift;
> foreach my $local_namespace (@tracked_namespaces) {
> - my $namespace_id = get_mw_namespace_id($local_namespace);
> + my ($namespace_id, $mw_pages);
> + if ($local_namespace eq "(Main)") {
> + $namespace_id = 0;
> + } else {
> + $namespace_id = get_mw_namespace_id($local_namespace);
> + }
I meant to ask this in the previous round, but with the earlier patch
mixing several distinct changes into one, I plumb forgot: Would it
make sense to move this "(Main)" special case into
get_mw_namespace_id() itself? After all, that function is all about
determining an ID associated with a name, and "(Main)" is a name.
> next if $namespace_id < 0; # virtual namespaces don't support allpages
> - my $mw_pages = $mediawiki->list( {
> + $mw_pages = $mediawiki->list( {
Why did the "my" of $my_pages get moved up to the top of the foreach
loop? I can't seem to see any reason for it. Is this an unrelated
change accidentally included in this patch?
> action => 'query',
> list => 'allpages',
> apnamespace => $namespace_id,
> --
next prev parent reply other threads:[~2017-11-01 19:56 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-29 16:08 [PATCH 0/4] WIP: git-remote-media wiki namespace support Antoine Beaupré
2017-10-29 16:08 ` [PATCH 1/4] remote-mediawiki: add " Antoine Beaupré
2017-10-29 17:24 ` Eric Sunshine
2017-10-29 18:29 ` Antoine Beaupré
2017-10-29 20:07 ` Eric Sunshine
2017-10-29 23:08 ` Kevin
2017-10-30 2:14 ` Antoine Beaupré
2017-10-30 2:51 ` [PATCH v2 0/7] " Antoine Beaupré
2017-10-30 2:51 ` [PATCH 1/7] " Antoine Beaupré
2017-10-30 2:51 ` [PATCH 2/7] remote-mediawiki: allow fetching namespaces with spaces Antoine Beaupré
2017-10-30 2:51 ` [PATCH 3/7] remote-mediawiki: show known namespace choices on failure Antoine Beaupré
2017-10-30 2:51 ` [PATCH 4/7] remote-mediawiki: skip virtual namespaces Antoine Beaupré
2017-11-01 13:52 ` Eric Sunshine
2017-11-01 16:45 ` Antoine Beaupré
2017-11-02 1:24 ` Junio C Hamano
2017-11-02 21:20 ` Antoine Beaupré
2017-11-06 0:38 ` Junio C Hamano
2017-10-30 2:51 ` [PATCH 5/7] remote-mediawiki: support fetching from (Main) namespace Antoine Beaupré
2017-11-01 19:56 ` Eric Sunshine [this message]
2017-11-02 21:19 ` Antoine Beaupré
2017-10-30 2:51 ` [PATCH 6/7] remote-mediawiki: process namespaces in order Antoine Beaupré
2017-11-01 19:59 ` Eric Sunshine
2017-10-30 2:51 ` [PATCH 7/7] remote-mediawiki: show progress while fetching namespaces Antoine Beaupré
2017-11-01 20:01 ` Eric Sunshine
2017-11-02 21:25 ` [PATCH v3 0/7] remote-mediawiki: namespace support Antoine Beaupré
2017-11-02 21:25 ` [PATCH v3 1/7] remote-mediawiki: add " Antoine Beaupré
2017-11-02 21:25 ` [PATCH v3 2/7] remote-mediawiki: allow fetching namespaces with spaces Antoine Beaupré
2017-11-02 21:25 ` [PATCH v3 3/7] remote-mediawiki: show known namespace choices on failure Antoine Beaupré
2017-11-02 21:25 ` [PATCH v3 4/7] remote-mediawiki: skip virtual namespaces Antoine Beaupré
2017-11-02 22:43 ` Eric Sunshine
2017-11-02 22:54 ` Antoine Beaupré
2017-11-02 21:25 ` [PATCH v3 5/7] remote-mediawiki: support fetching from (Main) namespace Antoine Beaupré
2017-11-02 22:48 ` Eric Sunshine
2017-11-02 21:25 ` [PATCH v3 6/7] remote-mediawiki: process namespaces in order Antoine Beaupré
2017-11-02 22:49 ` Eric Sunshine
2017-11-02 21:25 ` [PATCH v3 7/7] remote-mediawiki: show progress while fetching namespaces Antoine Beaupré
2017-11-02 22:18 ` Thomas Adam
2017-11-02 22:26 ` Antoine Beaupré
2017-11-02 22:31 ` Thomas Adam
2017-11-02 23:10 ` Antoine Beaupré
2017-11-04 9:57 ` Thomas Adam
2017-11-02 22:50 ` Eric Sunshine
2017-11-06 21:19 ` [PATCH v4 0/7] remote-mediawiki: namespace support Antoine Beaupré
2017-11-06 21:19 ` [PATCH v4 1/7] remote-mediawiki: add " Antoine Beaupré
2017-11-06 21:19 ` [PATCH v4 2/7] remote-mediawiki: allow fetching namespaces with spaces Antoine Beaupré
2017-11-07 7:08 ` Thomas Adam
2017-11-07 16:03 ` Antoine Beaupré
2017-11-06 21:19 ` [PATCH v4 3/7] remote-mediawiki: show known namespace choices on failure Antoine Beaupré
2017-11-07 10:45 ` Thomas Adam
2017-11-07 16:07 ` Antoine Beaupré
2017-11-06 21:19 ` [PATCH v4 4/7] remote-mediawiki: skip virtual namespaces Antoine Beaupré
2017-11-06 21:19 ` [PATCH v4 5/7] remote-mediawiki: support fetching from (Main) namespace Antoine Beaupré
2017-11-06 21:19 ` [PATCH v4 6/7] remote-mediawiki: process namespaces in order Antoine Beaupré
2017-11-06 21:19 ` [PATCH v4 7/7] remote-mediawiki: show progress while fetching namespaces Antoine Beaupré
2017-11-07 16:06 ` [PATCH v5 0/7] namespace support Antoine Beaupré
2017-11-07 16:06 ` [PATCH v5 1/7] remote-mediawiki: add " Antoine Beaupré
2017-11-07 16:06 ` [PATCH v5 2/7] remote-mediawiki: allow fetching namespaces with spaces Antoine Beaupré
2017-11-07 16:06 ` [PATCH v5 3/7] remote-mediawiki: show known namespace choices on failure Antoine Beaupré
2017-11-07 16:06 ` [PATCH v5 4/7] remote-mediawiki: skip virtual namespaces Antoine Beaupré
2017-11-07 16:06 ` [PATCH v5 5/7] remote-mediawiki: support fetching from (Main) namespace Antoine Beaupré
2017-11-07 16:07 ` [PATCH v5 6/7] remote-mediawiki: process namespaces in order Antoine Beaupré
2017-11-07 16:07 ` [PATCH v5 7/7] remote-mediawiki: show progress while fetching namespaces Antoine Beaupré
2017-11-08 2:07 ` [PATCH v5 0/7] namespace support Junio C Hamano
2017-10-30 10:43 ` [PATCH 1/4] remote-mediawiki: add " Matthieu Moy
2017-10-29 16:08 ` [PATCH 2/4] remote-mediawiki: allow fetching namespaces with spaces Antoine Beaupré
2017-10-29 16:08 ` [PATCH 3/4] remote-mediawiki: show known namespace choices on failure Antoine Beaupré
2017-10-29 17:34 ` Eric Sunshine
2017-10-29 18:31 ` Antoine Beaupré
2017-11-04 10:57 ` Thomas Adam
2017-10-29 16:08 ` [PATCH 4/4] remote-mediawiki: allow using (Main) as a namespace and skip special namespaces Antoine Beaupré
2017-10-29 19:49 ` Eric Sunshine
2017-10-30 2:11 ` Antoine Beaupré
2017-10-30 3:49 ` Eric Sunshine
2017-10-30 2:43 ` Antoine Beaupré
2017-10-30 3:52 ` Eric Sunshine
2017-10-30 12:17 ` Antoine Beaupré
2017-10-30 10:40 ` [PATCH 0/4] WIP: git-remote-media wiki namespace support Matthieu Moy
2017-10-30 12:20 ` Antoine Beaupré
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cTX1kBCk-phodTanU1dmwjM_2TNevKyGvdCWonqhEU5Dg@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=anarcat@debian.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).