From: Eric Sunshine <sunshine@sunshineco.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Marc-André Lureau" <marcandre.lureau@gmail.com>,
"SZEDER Gábor" <szeder.dev@gmail.com>,
"Git List" <git@vger.kernel.org>
Subject: Re: [PATCH] branch: let '--edit-description' default to rebased branch during rebase
Date: Fri, 7 Feb 2020 14:29:11 -0500 [thread overview]
Message-ID: <CAPig+cTWxj+dRiYZEEbfUA7=NiEF3crTaYCVGPR2qG-VEV+Y0w@mail.gmail.com> (raw)
In-Reply-To: <xmqqwo8y2ovu.fsf@gitster-ct.c.googlers.com>
On Fri, Feb 7, 2020 at 2:12 PM Junio C Hamano <gitster@pobox.com> wrote:
> Marc-André Lureau <marcandre.lureau@gmail.com> writes:
> > Then --edit-description during won't default to the branch you started
> > from the bisect. So we are back to my original proposal only, having
> > branch default during rebase. Eric, do you mind?
I don't feel strongly one way or the other.
> > > How about teaching "git branch --edit-description [HEAD]" notice
> > > when/if HEAD is detached and always error out, no matter what
> > > operation is in progress?
>
> What I meant by "no matter what is in progress" is not to special
> case "during rebase", either.
That would defeat the original purpose[1] of this submission, I think.
As I understand it, the idea all along was to make this operation work
during a rebase.
[1]: https://lore.kernel.org/git/20200110071929.119000-1-marcandre.lureau@redhat.com/
next prev parent reply other threads:[~2020-02-07 19:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-11 12:35 [PATCH] branch: let '--edit-description' default to rebased branch during rebase marcandre.lureau
2020-01-11 13:26 ` Eric Sunshine
2020-01-11 14:54 ` Marc-André Lureau
2020-01-12 1:27 ` Eric Sunshine
2020-01-12 6:44 ` Marc-André Lureau
2020-01-12 12:14 ` SZEDER Gábor
2020-01-13 1:59 ` Eric Sunshine
2020-01-24 22:41 ` SZEDER Gábor
2020-01-30 21:37 ` Marc-André Lureau
2020-01-31 15:52 ` SZEDER Gábor
2020-01-31 15:59 ` Marc-André Lureau
2020-01-31 16:16 ` SZEDER Gábor
2020-02-06 22:26 ` Marc-André Lureau
2020-02-07 10:02 ` SZEDER Gábor
2020-02-07 14:16 ` Marc-André Lureau
2020-02-07 18:57 ` Junio C Hamano
2020-02-07 19:09 ` Marc-André Lureau
2020-02-07 19:12 ` Junio C Hamano
2020-02-07 19:29 ` Eric Sunshine [this message]
2020-02-07 20:14 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cTWxj+dRiYZEEbfUA7=NiEF3crTaYCVGPR2qG-VEV+Y0w@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=marcandre.lureau@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).