git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: Derrick Stolee <stolee@gmail.com>
Cc: Git List <git@vger.kernel.org>,
	Clement Moyroud <clement.moyroud@gmail.com>
Subject: Re: [PATCH] maintenance: fix incorrect `maintenance.repo` path with bare repository
Date: Tue, 23 Feb 2021 11:21:46 -0500	[thread overview]
Message-ID: <CAPig+cTWZSe+e5JnTLMDt+F7NxdLG0fFqqSavkyo_YN7B7Affg@mail.gmail.com> (raw)
In-Reply-To: <5653230a-20c2-321f-7ea0-93ce59858532@gmail.com>

On Tue, Feb 23, 2021 at 7:26 AM Derrick Stolee <stolee@gmail.com> wrote:
> On 2/23/2021 2:31 AM, Eric Sunshine wrote:
> > +test_expect_success 'register and unregister bare repo' '
> > +     test_when_finished "git config --global --unset-all maintenance.repo || :" &&
> > +     test_might_fail git config --global --unset-all maintenance.repo &&
> > +     git init --bare barerepo &&
> > +     (
> > +             cd barerepo &&
> > +             git maintenance register &&
> > +             git config --get --global --fixed-value maintenance.repo "$(pwd)" &&
>
> I'm concerned about this test passing on Windows, but if the CI build is happy,
> then I'm happy.

I had a slight worry about Windows, as well, but (1) this is copied
directly from an earlier test in this script which does pass on
Windows, and (2) I tested on Windows, and it works fine. So, all is
good.

> Reviewed-by: Derrick Stolee <dstolee@microsoft.com>

Thanks.

      reply	other threads:[~2021-02-23 16:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-23  7:31 [PATCH] maintenance: fix incorrect `maintenance.repo` path with bare repository Eric Sunshine
2021-02-23 12:25 ` Derrick Stolee
2021-02-23 16:21   ` Eric Sunshine [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPig+cTWZSe+e5JnTLMDt+F7NxdLG0fFqqSavkyo_YN7B7Affg@mail.gmail.com \
    --to=sunshine@sunshineco.com \
    --cc=clement.moyroud@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=stolee@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).