From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 235031F8C6 for ; Sun, 12 Sep 2021 05:53:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229704AbhILFyt convert rfc822-to-8bit (ORCPT ); Sun, 12 Sep 2021 01:54:49 -0400 Received: from mail-ej1-f48.google.com ([209.85.218.48]:38477 "EHLO mail-ej1-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229535AbhILFys (ORCPT ); Sun, 12 Sep 2021 01:54:48 -0400 Received: by mail-ej1-f48.google.com with SMTP id n27so13338458eja.5 for ; Sat, 11 Sep 2021 22:53:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=wFTLxIIh57bEar4rv4lMs5vPIP7VjFTEriHsFmGsxK8=; b=mVgHKe2r7zBasjkUIzQo/Cgjl+CRXWHSBTPI7JBQKrSrzYYCEukXRdA8akuOfO3XC5 hDfmckgGGr5By16rlMLyaSo7OunrZSYKG9Gj48Ja4ptrr2ugmti6SXUz1CXpMfA4kbqi PHUnVv8nxSTc9fxjQQxnJ8m+pQtD+cV56DA2PUsaoSeDKNVc6i6zf3C06e9sOZGVdYLE fgO2Mco2NpDvB9XhVhOs7bQvD2z8d8OybNzsYwcRQfzFVFxA41zNQoUQ0DY3ZqHQlDvo flq4F0pOzIkm2tzyo2LJSjoXn31FMj2oNIqW0ysUJMmjartuPaQtJ7aArZItxhm0XRvj WXWQ== X-Gm-Message-State: AOAM530JZX5z8d6Bxpls/viqhZ05UrMU5hiz+JUWS4HrOFJVFe3qXW7i c4WBvgltctNa3823xx7LSxmFBqciGl51hNxIfLHy2rs1 X-Google-Smtp-Source: ABdhPJyTNRYDijz+mDNYvZSmkG6eu1YMTqPTvcip0NCjnim4H9E2j6YZklHJ7pz/LyIbmw1ksA0LFBXBuzPwWNARonA= X-Received: by 2002:a17:906:15cf:: with SMTP id l15mr6000100ejd.568.1631426014010; Sat, 11 Sep 2021 22:53:34 -0700 (PDT) MIME-Version: 1.0 References: <20210830072118.91921-1-sunshine@sunshineco.com> <20210830072118.91921-4-sunshine@sunshineco.com> <878s03c1of.fsf@evledraar.gmail.com> <87wnnn8kba.fsf@evledraar.gmail.com> In-Reply-To: <87wnnn8kba.fsf@evledraar.gmail.com> From: Eric Sunshine Date: Sun, 12 Sep 2021 01:53:23 -0400 Message-ID: Subject: Re: [PATCH 3/3] notes: don't indent empty lines To: =?UTF-8?B?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= Cc: Junio C Hamano , Git List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Sat, Sep 11, 2021 at 6:43 AM Ævar Arnfjörð Bjarmason wrote: > On Sat, Sep 11 2021, Eric Sunshine wrote: > > Notes don't store the indented blank lines; it's only at output time, > > such as with `git format-patch --notes` that the blank lines get > > indented along with the rest of the note text (just as is happening in > > your `git show` example in which the entire commit message is being > > indented, including the blank lines). > > Ah, so with your change we'd end up with trimmed notes, but not the > trimmed main body of the commit message? That's correct. This "fix" is specific to the note-printing machinery which is invoked by (at least) git-format-patch and git-log. (Until your demonstration of git-show indentation, I wasn't even aware that blank lines in commit messages were getting indented there, as well.) > > Anyhow, since then, I've discovered that `git format-patch > > --range-diff` also indents blank lines. And you've now shown that `git > > show` does, as well, so the behavior which triggered this "fix" turns > > out to be somewhat normal in this project, rather than a one-off "bug" > > in need of a fix. > > Per the above I wouldn't mind this just being changed for all of them, > even one at a time. I'm not a fan of the trailing whitespace either, however, Junio does have the concern that there may be some tooling somewhere which relies upon the "indented blank lines" (even if such tooling would not be robust).