From: Eric Sunshine <sunshine@sunshineco.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: tb/commit-graph-tests (was: Re: What's cooking in git.git (Jul 2023, #06; Thu, 27))
Date: Tue, 1 Aug 2023 14:33:23 -0400 [thread overview]
Message-ID: <CAPig+cTRUac+FRg6V1H+3_rusT17imQGZOy8Fd-MWriEv_epRQ@mail.gmail.com> (raw)
In-Reply-To: <ZMfhWkd24y7XjEIw@nand.local>
On Mon, Jul 31, 2023 at 12:55 PM Taylor Blau <me@ttaylorr.com> wrote:
> On Thu, Jul 27, 2023 at 06:46:42PM -0700, Junio C Hamano wrote:
> > * tb/commit-graph-tests (2023-07-24) 5 commits
> > Test updates.
> >
> > Will merge to 'next'?
> > source: <cover.1690216758.git.me@ttaylorr.com>
>
> I think this one is ready to go. Eric Sunshine gave the earlier round a
> review, and I made sure to address his feedback in the subsequent
> version.
>
> I'm happy to wait for an ACK from him, but I think this is low-risk
> enough that you could merge it as-is. Either way :-).
Yup, as I recall, I gave v1 a reasonably thorough read. When the
reroll arrived, I scanned the range-diff and saw that the few minor
review comments had been addressed, thus I had nothing more to add.
next prev parent reply other threads:[~2023-08-01 18:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 1:46 What's cooking in git.git (Jul 2023, #06; Thu, 27) Junio C Hamano
2023-07-28 2:13 ` Jacob Abel
2023-07-28 5:11 ` Junio C Hamano
2023-07-30 1:35 ` Rubén Justo
2023-07-31 16:29 ` tb/commit-graph-tests (was: Re: What's cooking in git.git (Jul 2023, #06; Thu, 27)) Taylor Blau
2023-08-01 18:33 ` Eric Sunshine [this message]
2023-08-01 20:50 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cTRUac+FRg6V1H+3_rusT17imQGZOy8Fd-MWriEv_epRQ@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).