From: Eric Sunshine <sunshine@sunshineco.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Alban Gruin <alban.gruin@gmail.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH v1] git-clone.txt: add the --recursive option
Date: Tue, 14 Sep 2021 13:53:11 -0400 [thread overview]
Message-ID: <CAPig+cTQNkwWgpgu-Mw=Qd++cUVnFrrdnaQnaSZ79RexnNQFHg@mail.gmail.com> (raw)
In-Reply-To: <xmqqbl4v2gpu.fsf@gitster.g>
On Tue, Sep 14, 2021 at 1:46 PM Junio C Hamano <gitster@pobox.com> wrote:
> I am wondering if it is just a matter of either
>
> * removing the "recursive" alias from the options table. Because
> we accept unique prefix, --recurse=<arg> the user types will be
> taken as --recurse-submodules=<arg> anyway (until "git clone"
> learns another option --recurse-xyzzy=<arg>, at which time it
> will become ambiguous and error out, that is).
With this option, we risk breaking existing tooling which happens to
use the deprecated --recursive.
> or
>
> * adding the PARSE_OPT_HIDDEN bit to the OPT_ALIAS() element for
> the deprecated "recurse" option.
I was going to suggest this as a possible way forward to address
Alban's most recent response to my response. The lack of
PARSE_OPT_HIDDEN on OPT_ALIAS() almost seems like an oversight.
> Between adding "--recursive" to the manual and describing it as a
> deprecated synonym for "--recurse-submodules", and not doing so, I
> do not have a strong preference.
I don't have a strong preference either, especially considering how
long ago --recursive was removed from the manual, however, adding it
would help someone who runs across --recursive in existing tooling or
old blog post and wants to know what it does.
next prev parent reply other threads:[~2021-09-14 17:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 18:59 [PATCH v1] git-clone.txt: add the --recursive option Alban Gruin
2021-09-13 19:26 ` Eric Sunshine
2021-09-13 20:42 ` Alban Gruin
2021-09-13 21:57 ` Eric Sunshine
2021-09-14 10:27 ` Alban Gruin
2021-09-14 17:46 ` Junio C Hamano
2021-09-14 17:53 ` Eric Sunshine [this message]
2021-09-14 18:31 ` Junio C Hamano
2021-09-14 20:21 ` Re* " Junio C Hamano
2021-09-13 21:43 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cTQNkwWgpgu-Mw=Qd++cUVnFrrdnaQnaSZ79RexnNQFHg@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=alban.gruin@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).