From: Eric Sunshine <sunshine@sunshineco.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git List <git@vger.kernel.org>, Duy Nguyen <pclouds@gmail.com>
Subject: Re: [PATCH v2] Documentation/git-worktree: fix stale "git checkout --to" references
Date: Thu, 16 Jul 2015 19:26:32 -0400 [thread overview]
Message-ID: <CAPig+cTPfOs-VkkDJ3LNrQ3ZC14PixOcx_Y4k=pMjMOYVHzO=g@mail.gmail.com> (raw)
In-Reply-To: <xmqq4ml34snd.fsf@gitster.dls.corp.google.com>
On Thu, Jul 16, 2015 at 6:57 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Eric Sunshine <sunshine@sunshineco.com> writes:
>> These should have been changed to "git worktree add" by fc56361
>> (worktree: introduce "add" command, 2015-07-06.
>>
>> Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
>> ---
> By the way, given the rate of bugs and glitches I am finding in this
> code with a very superficial use in real work only for a few days,
> perhaps we would want to add a warning to the documentation of "git
> worktree", in addition to the "this is still experimental" mention
> in the release notes, to discourage people to keep their only copy
> of the work in a secondary worktree for now?
>
> BUGS
> ----
> -Multiple checkout support for submodules is incomplete. It is NOT
> -recommended to make multiple checkouts of a superproject.
> +Multiple checkout in general is still experimental, and the support
> +for submodules is incomplete. It is NOT recommended to make multiple
> +checkouts of a superproject.
Maybe, maybe not.
The submodule item is at least (hopefully) quantitative. That is,
there should be some point after specific shortcomings have been
addressed when we can say "submodules are now supported", and remove
the item from BUGS.
But, "in general is still experimental" is nebulous and open-ended. At
what point do we stop considering it experimental, and who will
remember to remove the entry from BUGS when that day comes?
Other than that concern, the revised text seems reasonable.
prev parent reply other threads:[~2015-07-16 23:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 22:09 [PATCH v2] Documentation/git-worktree: fix stale "git checkout --to" references Eric Sunshine
2015-07-16 22:57 ` Junio C Hamano
2015-07-16 23:26 ` Eric Sunshine [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cTPfOs-VkkDJ3LNrQ3ZC14PixOcx_Y4k=pMjMOYVHzO=g@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).