From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS54825 147.75.192.0/21 X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org [147.75.199.223]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 260061F406 for ; Thu, 26 Oct 2023 20:13:59 +0000 (UTC) Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 5A7BD1C20F73 for ; Thu, 26 Oct 2023 20:13:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F349D3CCFA; Thu, 26 Oct 2023 20:13:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80BB43C078 for ; Thu, 26 Oct 2023 20:13:47 +0000 (UTC) Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D209D129 for ; Thu, 26 Oct 2023 13:13:45 -0700 (PDT) Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-66d0169cf43so8931666d6.3 for ; Thu, 26 Oct 2023 13:13:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698351225; x=1698956025; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Azz+2f0kITU+tCwFi6A63rUE+Pui1j3b+UvyIfDszYs=; b=F//uQlJ+RdJGz6kHUcvVnfJ6iKlobzeB9NRNasGHyTEMDIZvYCCEDcowhOoiqVbrDG O21eJmxbXhNphE3nBc+XvL3epqzZn1pvMSenTjsUIq/CXj31laix0fKpmLKXzNehKbGx gRm/e4EB3niO042X+4qg/mxRirCK+gOpf7oo+W6KrSfyIpQBffz5Gu04dZHjzJ0X/Jqh 7x7bYG+odQqAC0aU598DtFjm3j5pO2Hf5UT18IYUknXYz6xQvJitNqoHFv3cALsQYLtZ Q2vu2CWQtie80RboiXng4MT5HNhkmPuNJyKo6riWyN5r+3E9CM/RnWxPETrhtxUswgHK IXQA== X-Gm-Message-State: AOJu0YzdobWLOL/Do6KzHF3CV4MyH8ZRhN+cXx3KzRQUZel0MEgyAlxb OtvHhrGPmFSS9sM080NQ0GbkqlsxN5K6EzL5U+0= X-Google-Smtp-Source: AGHT+IGnNRX/j8RkHo9s8uS3wETt7B8S701H0gThTlgnPVO5vhj1+etLgmFJ7CdPffY6R0fPJAScCOi+5vbE0YyWAn8= X-Received: by 2002:a05:6214:27cb:b0:66d:f94:522d with SMTP id ge11-20020a05621427cb00b0066d0f94522dmr766060qvb.47.1698351224716; Thu, 26 Oct 2023 13:13:44 -0700 (PDT) Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: , MIME-Version: 1.0 References: <20231026155459.2234929-1-nasamuffin@google.com> <20231026182231.3369370-1-nasamuffin@google.com> In-Reply-To: <20231026182231.3369370-1-nasamuffin@google.com> From: Eric Sunshine Date: Thu, 26 Oct 2023 16:13:33 -0400 Message-ID: Subject: Re: [PATCH v4 0/2] bugreport: reject positional arguments To: emilyshaffer@google.com Cc: git@vger.kernel.org, Emily Shaffer , Sheik , Dragan Simic Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Unsubscribe-Post: List-Unsubscribe=One-Click On Thu, Oct 26, 2023 at 2:22=E2=80=AFPM wrote: > The test I cribbed from for the newly added one in patch 2 was still > using test_i18ngrep, and Eric mentioned us not wanting i18ngrep at all > anymore, so I went ahead and cleaned that up as well. Thanks for making the various tweaks in response to my review comments.