From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id D15EB1F953 for ; Tue, 28 Dec 2021 09:12:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235831AbhL1JMH (ORCPT ); Tue, 28 Dec 2021 04:12:07 -0500 Received: from mail-pg1-f170.google.com ([209.85.215.170]:45898 "EHLO mail-pg1-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233036AbhL1JMH (ORCPT ); Tue, 28 Dec 2021 04:12:07 -0500 Received: by mail-pg1-f170.google.com with SMTP id 2so15476517pgb.12 for ; Tue, 28 Dec 2021 01:12:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OGRJ2xQSLqz6kH3JPdeu8SZbU8YqFOqn/1XIBEAN6Ro=; b=XhioVTKt7okRYNUpWPgi5IfZIsYl23iQKRRYD8ARohGeXIFHS4FEVPmlatAudsBXPK vOstYsk/f7kO3ycLqFTVySM6HB9E9BnO87oBYFqM6p5M+4euZxen77azEyBjrSvos40O z2y0iBGUOU+3CR6/sGWSo1F4HPvYeG8AN/VYGh9RsE3fI5WhomwjDI7L2h4CEiuU9E2i MHw+eM8R2mphBBNeCZyKikL75PAJnc8xfYxOqhG6hvKzZ9tI55LHR8UIyefU2zFSn48F IPvUGFsfjS7Mj42UaJZNVX5PHRhd7Tj3sTNA7VGbXt4AnD9M3ko3igz87plFvIGQ+xJH SaSw== X-Gm-Message-State: AOAM531+g1d7DW9Oq9dV8z+qQs6DWm8dSD1Qu3by8Z5WYmX67hKKsK7p LAssYH8hhdjK4ltJfqM02sOQzU8ovSEg59OI6GbqGZXU5pY= X-Google-Smtp-Source: ABdhPJxIadQL1ecG/DOXn0gTvoNo3rJYbwSGqnPKxeXEkzDEEUC04DTBakvX/fWelmN5IPD817bBnQ+vZnQNLVHlU2I= X-Received: by 2002:a63:380e:: with SMTP id f14mr18550987pga.227.1640682726733; Tue, 28 Dec 2021 01:12:06 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Eric Sunshine Date: Tue, 28 Dec 2021 04:11:55 -0500 Message-ID: Subject: Re: [PATCH v2 0/5] Sparse checkout: fix bug with worktree of bare repo To: Elijah Newren Cc: Derrick Stolee via GitGitGadget , Git Mailing List , Derrick Stolee , Sean Allred , Junio C Hamano , Derrick Stolee Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Dec 27, 2021 at 3:16 PM Elijah Newren wrote: > On Sun, Dec 26, 2021 at 11:34 PM Eric Sunshine wrote: > > Your proposal is _almost_ the same as my suggestion of eventually > > making per-worktree config the default. The difference is that you're > > only making it the default if `core.bare=true` or `core.worktree` is > > set. > > Indeed. :-) > > > But do we need that distinction? If people are comfortable with > > that, then are they comfortable with simply flipping the switch and > > making per-worktree config the default today regardless of `core.bare` > > and `core.worktree`? > > This is tempting, at least if we leave core.repositoryFormatVersion as > 0 (see 11664196ac ("Revert "check_repository_format_gently(): refuse > extensions for old repositories"", 2020-07-15)) when core.bare is > false and core.worktree was unset. However, for that case: I'll try to respond to this email when I can find a quiet block of time to really concentrate on what you're saying and reason through it more thoroughly; it will probably require several read-throughs.