From: Eric Sunshine <sunshine@sunshineco.com>
To: Michal Suchanek <msuchanek@suse.de>
Cc: "Git List" <git@vger.kernel.org>,
"Marketa Calabkova" <mcalabkova@suse.cz>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH 2/2] setup: don't fail if commondir reference is deleted.
Date: Mon, 18 Feb 2019 16:00:27 -0500 [thread overview]
Message-ID: <CAPig+cTA1hNXMiKb5Jwk3k+xfgCv-+B2HzdoJFLN9Fa5cN4NKg@mail.gmail.com> (raw)
In-Reply-To: <6f9c8775817117c2b36539eb048e2462a650ab8f.1550508544.git.msuchanek@suse.de>
On Mon, Feb 18, 2019 at 12:05 PM Michal Suchanek <msuchanek@suse.de> wrote:
> When adding wotktrees git can die in get_common_dir_noenv while
> examining existing worktrees because the commondir file does not exist.
> Rather than testing if the file exists before reading it handle ENOENT.
This commit message leaves the reader wondering under what conditions
"commondir file" might not exist. For instance, the reader might
wonder "iIs it simply a condition of normal operation or does it arise
under odd circumstances?". Without this information, it is difficult
for someone reading the explanation to understand if or how this code
might validly be changed in the future. Your cover letter contained
explanation which likely ought to be duplicated here as an aid to
future readers.
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
next prev parent reply other threads:[~2019-02-18 21:00 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 17:04 [PATCH 0/2] worktree add race fix Michal Suchanek
2019-02-18 17:04 ` [PATCH 1/2] worktree: fix worktree add race Michal Suchanek
2019-02-18 17:04 ` [PATCH 2/2] setup: don't fail if commondir reference is deleted Michal Suchanek
2019-02-18 21:00 ` Eric Sunshine [this message]
2019-02-21 10:50 ` Duy Nguyen
2019-02-21 13:50 ` Michal Suchánek
2019-02-21 17:07 ` Phillip Wood
2019-02-21 17:12 ` Eric Sunshine
2019-02-21 17:27 ` Phillip Wood
2019-03-04 13:30 ` Michal Suchánek
2019-02-21 17:33 ` Michal Suchánek
2019-02-22 9:32 ` Duy Nguyen
2019-02-22 10:20 ` Phillip Wood
2019-02-22 9:26 ` Duy Nguyen
2019-02-20 16:16 ` [PATCH v3 1/2] worktree: fix worktree add race Michal Suchanek
2019-02-20 16:34 ` Eric Sunshine
2019-02-20 17:29 ` Michal Suchánek
2019-03-08 9:20 ` Duy Nguyen
2019-03-08 9:37 ` Eric Sunshine
2019-03-11 1:55 ` Junio C Hamano
2019-02-20 16:16 ` [PATCH v3 2/2] setup: don't fail if commondir reference is deleted Michal Suchanek
2019-02-20 16:55 ` Eric Sunshine
2019-02-20 17:16 ` Michal Suchánek
2019-02-20 18:35 ` Eric Sunshine
2019-02-21 9:27 ` Eric Sunshine
2019-02-21 11:13 ` Michal Suchánek
2019-02-21 11:19 ` Michal Suchánek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cTA1hNXMiKb5Jwk3k+xfgCv-+B2HzdoJFLN9Fa5cN4NKg@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mcalabkova@suse.cz \
--cc=msuchanek@suse.de \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).