From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.7 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.6 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id DB77B1F452 for ; Fri, 21 Apr 2023 19:13:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233236AbjDUTNO convert rfc822-to-8bit (ORCPT ); Fri, 21 Apr 2023 15:13:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231639AbjDUTNL (ORCPT ); Fri, 21 Apr 2023 15:13:11 -0400 Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A63DA10E9 for ; Fri, 21 Apr 2023 12:13:10 -0700 (PDT) Received: by mail-qv1-f54.google.com with SMTP id 6a1803df08f44-5ef5a51d23aso17655896d6.1 for ; Fri, 21 Apr 2023 12:13:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682104390; x=1684696390; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2veretGAse/zWlQmiKkZf613LrDiW+sJ8usJOaIbfmA=; b=QLfrkBFEl+2m6xomp8TEsMZfpIksfUV1Epf8tF5vFaLKnrwDSM+yfSp9sJAMahDt8+ xmevW+G3PMyMmbjeaIvWmAuMD2O/U+Y2KpHMKQwSCI7LCtHWTqwHPtnlq9DO5+gY/eK+ W640/ENNOJ0i8c++XJCsnKC7wpls6SFLBsjgcohS/eOcxwb4UIxFWRNL/+DTcJjFqk63 vaNQDpirQBmgIOkazAIMRXQvotWHOhwIlf6gTzLhrfADWgUKbvd24xz0fSwPgbXhEfT/ aYFLdm7WDbgiawIF/K9xQebxEzmRc4qFHllUJlB3C5fLczmBgjJelwziz0yU9n5axtLD 7PFQ== X-Gm-Message-State: AAQBX9dOIvq640upNI4hXTpKRTBJfwggSClUgbO14tKCkRBPgg54J6Il rWYjXp/KR5p9DU29G9xvXTcKUajwoLrBP0o43rn3SKsT X-Google-Smtp-Source: AKy350Zet3G/ETUOvz/mJXW8coyMW5UzbHkeh+F7pF4HrNIO7QJ7bPQpqH1Ya9kNdL9GBpBbcOld1AfT6jMyaiQ8xJo= X-Received: by 2002:a05:6214:246a:b0:5ef:56e4:f629 with SMTP id im10-20020a056214246a00b005ef56e4f629mr12361833qvb.38.1682104389674; Fri, 21 Apr 2023 12:13:09 -0700 (PDT) MIME-Version: 1.0 References: <31bb644e769a085bd2db97cdb5aae78729efc52d.1682089075.git.gitgitgadget@gmail.com> In-Reply-To: <31bb644e769a085bd2db97cdb5aae78729efc52d.1682089075.git.gitgitgadget@gmail.com> From: Eric Sunshine Date: Fri, 21 Apr 2023 15:12:58 -0400 Message-ID: Subject: Re: [PATCH v2 3/6] sequencer: factor out part of pick_commits() To: Phillip Wood via GitGitGadget Cc: git@vger.kernel.org, Johannes Schindelin , Junio C Hamano , Stefan Haller , Phillip Wood , Phillip Wood Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Apr 21, 2023 at 11:11 AM Phillip Wood via GitGitGadget wrote: > This is simplifies a change in a later commit. If a pick fails we now s/This is/This/ > return the error at then end of the loop body rather than returning s/then end/the end/ > early but there is no change in behavior. > > Signed-off-by: Phillip Wood