mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Eric Sunshine <>
To: Paul-Sebastian Ungureanu <>
Cc: Git List <>
Subject: Re: [GSoC][PATCH v6] parse-options: do not show usage upon invalid option value
Date: Tue, 20 Mar 2018 14:36:54 -0400	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Tue, Mar 20, 2018 at 1:50 PM, Paul-Sebastian Ungureanu
<> wrote:
> Usually, the usage should be shown only if the user does not know what
> options are available. If the user specifies an invalid value, the user
> is already aware of the available options. In this case, there is no
> point in displaying the usage anymore.
> This patch applies to "git tag --contains", "git branch --contains",
> "git branch --points-at", "git for-each-ref --contains" and many more.
> Signed-off-by: Paul-Sebastian Ungureanu <>
> ---

As this is a very active mailing list, with reviewers poring over many
(sometimes dozens of) patches each day, it is easy for a reviewer to
forget exact details of each individual submission and review comment.
As a patch contributor, you can help ease reviewers' burden by adding
commentary to your submission here, below the "---" line following
your sign-off. In particular, reviewers find it very helpful when you:

* describe in some detail what changed since the previous version of
the patch, showing that you understood and took into consideration
each of the review comments from the previous iteration

* a link, like this[1], pointing at the previous round (and perhaps
further back) so reviewers can refresh their memories about issues
raised previously; this also helps people wanting to review this round
who were not involved in earlier rounds


  reply	other threads:[~2018-03-20 18:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-20 17:50 [GSoC][PATCH v6] parse-options: do not show usage upon invalid option value Paul-Sebastian Ungureanu
2018-03-20 18:36 ` Eric Sunshine [this message]
2018-03-22 18:34   ` Paul-Sebastian Ungureanu
2018-03-21 18:22 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='' \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).