From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 0EFF31F953 for ; Sun, 7 Nov 2021 01:51:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233921AbhKGByF convert rfc822-to-8bit (ORCPT ); Sat, 6 Nov 2021 21:54:05 -0400 Received: from mail-ed1-f47.google.com ([209.85.208.47]:37390 "EHLO mail-ed1-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229566AbhKGByE (ORCPT ); Sat, 6 Nov 2021 21:54:04 -0400 Received: by mail-ed1-f47.google.com with SMTP id f8so47645057edy.4 for ; Sat, 06 Nov 2021 18:51:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=l657dDspq4HLGlU9IuZAaTUkTcoSSmsd5JYn3RFNX3o=; b=gXR0zcFAxYPS2PomsTr70bM6yuYB6pO0qfzhYCKerJ1oZE+q8LEalZoG4yG05ZfJNu JmU1b7ylUmOjX27GfXEoGa07+5SzrJ+VE5dGFkgqLLTfL7g6BOalwYuQtZHREkbJV+lp I28URgSkWe88QClDCKnf+zLpks0PcUJkOvKRcWqnebkxHrbV8m1oj0EIo9aBUewwtpF6 mLc55ayJwFBUf98vyyo+/k+WIvuRT9QBqC0fnQYsSqAX2IvyO2VgyqpzSTu4qTFveXkx /vfMjQfuC05rz9nE0GLsOVnHmLZdcV+PTuZH4Xhm9GLAigKINLK6CD+mMqzkP92zA9ZV v5KA== X-Gm-Message-State: AOAM530OHfe9YKR8cJfBNNzno4hQ3SmEzT4hylmaLoSLad5e6TCSovtv h/wQD9Bw7siJynzEqudgBzWnt/fuqa5E60tANisxIrJ6Y+0= X-Google-Smtp-Source: ABdhPJxKUtj62Orqyh3EU3GKcZCgGkZ8vRlp25M/ttUdajkJYjnKB77BsLJ+5coDlQkh9uijNpmCLCBnCniW5rgiDlk= X-Received: by 2002:a05:6402:50d0:: with SMTP id h16mr17765288edb.70.1636249881977; Sat, 06 Nov 2021 18:51:21 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Eric Sunshine Date: Sat, 6 Nov 2021 21:51:11 -0400 Message-ID: Subject: Re: [PATCH 05/16] Makefile: correct "GIT-PERL-{DEFINES,HEADER}" dependency graph To: =?UTF-8?B?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= Cc: Git List , Junio C Hamano , Phillip Wood , Jeff King , Dan Jacques , Eric Wong , Jonathan Nieder Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Sat, Nov 6, 2021 at 5:03 PM Ævar Arnfjörð Bjarmason wrote: > Fix several small issues with the dependency graph of the generated > "GIT-PERL-DEFINES" and "GIT-PERL-HEADER" files: > > 1. Folllow-up my 4070c9e09fc (Makefile: don't re-define PERL_DEFINES, > 2021-05-05) and move the rest of the assignments to PERL_DEFINES to > one place, and change it from depending on "localedir_relative_SQ" > instead of "localedir". > > The former is what we'll actually use, and while it's unlikely to > matter in practice (we'd just skip re-building these under > RUNTIME_PREFIX if the relative path was the same) it makes it > clearer what's going on here by bringing us to a 1=1 mapping of > these variables and what's subsequently used in the > "GIT-PERL-DEFINES", "GIT-PERL-HEADER" and "perl/build/lib/%.pm" > rules below. > > 2. We don't need the substitution of " " for ":" added in > 07d90eadb50 (Makefile: add Perl runtime prefix support, 2018-04-10), > let's drop it. This doesn't matter for the correctness of these files, > but makes it clear that (unlike GIT-BUILD-OPTIONS) they are not Too many spaces between "clear" and "that". Is the last sentence of this paragraph incomplete? > 3. Don't have "GIT-PERL-HEADER" depend on the "Makefile". That was a > lazy way to over-declare the dependencies added in > f6a0ad4be71 (Makefile: generate Perl header from template file, > 2018-04-10), now that our dependency graph is correct we can be > confident in dropping it. > > Signed-off-by: Ævar Arnfjörð Bjarmason