From: Eric Sunshine <sunshine@sunshineco.com>
To: Jeff King <peff@peff.net>
Cc: Dorian Taylor <dorian.taylor.lists@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
Jonathan Nieder <jrnieder@gmail.com>,
Git List <git@vger.kernel.org>,
Brandon Williams <bmwill@google.com>
Subject: Re: [PATCH] smart-http: document flush after "# service" line
Date: Sat, 3 Mar 2018 03:28:47 -0500 [thread overview]
Message-ID: <CAPig+cT4NhhZNaYYXZL3dqvVn++KrNSL1bQRtdPt4RqfPexAnA@mail.gmail.com> (raw)
In-Reply-To: <20180303052708.GF27689@sigill.intra.peff.net>
On Sat, Mar 3, 2018 at 12:27 AM, Jeff King <peff@peff.net> wrote:
> Subject: smart-http: document flush after "# service" line
>
> The http-protocol.txt spec fails to mention that a flush
> packet comes in the smart server response after sending any
> the "service" header.
"any the"?
> Technically the client code is actually ready to receive an
> arbitrary number of headers here, but since we haven't
> introduced any other headers in the past decade (and the
> client would just throw them away), let's not mention it in
> the spec.
>
> This fixes both BNF and the example. While we're fixing the
> latter, let's also add the missing flush after the ref list.
>
> Reported-by: Dorian Taylor <dorian.taylor.lists@gmail.com>
> Signed-off-by: Jeff King <peff@peff.net>
next prev parent reply other threads:[~2018-03-03 8:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 18:29 bug in HTTP protocol spec Dorian Taylor
2018-02-21 22:15 ` Jeff King
2018-02-21 23:50 ` Dorian Taylor
2018-02-22 5:37 ` Jonathan Nieder
2018-02-22 7:23 ` Dorian Taylor
2018-02-22 10:08 ` Jeff King
2018-02-22 16:16 ` Dorian Taylor
2018-02-22 20:02 ` Junio C Hamano
2018-02-22 20:12 ` Dorian Taylor
2018-03-03 5:27 ` [PATCH] smart-http: document flush after "# service" line Jeff King
2018-03-03 8:28 ` Eric Sunshine [this message]
2018-03-03 10:02 ` Jeff King
2018-02-22 17:52 ` bug in HTTP protocol spec Brandon Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cT4NhhZNaYYXZL3dqvVn++KrNSL1bQRtdPt4RqfPexAnA@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=bmwill@google.com \
--cc=dorian.taylor.lists@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).