From: Eric Sunshine <sunshine@sunshineco.com>
To: Rudy Rigot <rudy.rigot@gmail.com>
Cc: "Rudy Rigot via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org, "Jeff Hostetler" <git@jeffhostetler.com>,
"Taylor Blau" <me@ttaylorr.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Derrick Stolee" <derrickstolee@github.com>
Subject: Re: [PATCH v5] status: long status advice adapted to recent capabilities
Date: Tue, 15 Nov 2022 13:06:34 -0500 [thread overview]
Message-ID: <CAPig+cT2+nitwD64FzG=6FvO7eUn3q-cq_CmmYeOXxOMyzvUnw@mail.gmail.com> (raw)
In-Reply-To: <CANaDLW+Ec0kY4AW5dGvnCaHgcvFOZQZO5EAi595KbVKj7KDg3g@mail.gmail.com>
On Tue, Nov 15, 2022 at 12:46 PM Rudy Rigot <rudy.rigot@gmail.com> wrote:
> Thanks for the feedback, and I'll integrate it into a new patch, most
> likely today.
Thanks. I think this is _almost_ there; much more polished than
earlier iterations. Hopefully, one final reroll will make it complete.
> > To what does "this" refer? Is it this repository? Or something else?
>
> Hah, good point. The accurate answer is "the status of currently
> existing files is being cached, and we'll watch what files changed
> after now so we only run things on those next time". Obviously that
> would be too verbose for the inexperienced user hitting this, really
> this line is here to convey "if you run it again, it's probably going
> to be faster".
>
> Here are some ideas:
> - "but this result is currently being cached."
> - "but git status results are currently being cached." (true but not
> perfectly accurate since index updates don't only happen on git
> status)
> - "but untracked files are currently being cached." (not completely
> accurate, I believe the index is updated for all files; the untracked
> files are only the interesting ones for this specific performance
> consideration)
> - "but the results were cached, and your next runs may be faster."
>
> I could use some guidance on what would make most sense here. I
> strongly feel like the user should know of it since that's been what's
> been confusing the users of our very large repo specifically when
> their git status is temporarily slow; but I don't have any opinions at
> all about the right phrasing. For now, I'm planning to use the latter
> bullet point in my next patch because it's the most explicit, but I'd
> be glad to apply someone else's take on this instead.
Reading the proposals while wearing the hat of someone who has never
had to deal with speeding up untracked-file bookkeeping and who may
not even know that remedies are available (as discussed in the
documentation), I find that the first three bullet points convey no
meaning at all; they leave the reader hanging. The final bullet point,
on the other hand, tells the user something conclusive. I _very_ much
prefer the final proposal.
(In "but the results were cached, and your next runs may be faster.",
I might suggest dropping "your" -- i.e. "... and subsequent runs may
be faster".)
next prev parent reply other threads:[~2022-11-15 18:08 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-15 13:04 [PATCH] fsmonitor: long status advice adapted to the fsmonitor use case Rudy Rigot via GitGitGadget
2022-10-15 13:08 ` Rudy Rigot
2022-10-17 15:39 ` Jeff Hostetler
2022-10-17 16:59 ` Rudy Rigot
2022-10-20 12:56 ` Jeff Hostetler
2022-10-20 20:17 ` Rudy Rigot
2022-10-24 14:55 ` Jeff Hostetler
2022-10-29 0:06 ` [PATCH v2] status: long status advice adapted to recent capabilities Rudy Rigot via GitGitGadget
2022-11-02 19:45 ` Jeff Hostetler
2022-11-02 20:34 ` Rudy Rigot
2022-11-02 23:59 ` Taylor Blau
2022-11-03 14:28 ` Rudy Rigot
2022-11-04 8:52 ` Ævar Arnfjörð Bjarmason
2022-11-04 15:33 ` Rudy Rigot
2022-11-04 21:38 ` Taylor Blau
2022-11-02 21:27 ` [PATCH v3] " Rudy Rigot via GitGitGadget
2022-11-04 21:40 ` Taylor Blau
2022-11-07 20:02 ` Derrick Stolee
2022-11-07 23:19 ` Taylor Blau
2022-11-15 16:38 ` Jeff Hostetler
2022-11-07 20:01 ` Derrick Stolee
2022-11-07 20:20 ` Eric Sunshine
2022-11-07 20:31 ` Rudy Rigot
2022-11-10 4:46 ` [PATCH v4] " Rudy Rigot via GitGitGadget
2022-11-10 5:42 ` Eric Sunshine
2022-11-10 17:01 ` Rudy Rigot
2022-11-10 17:30 ` Eric Sunshine
2022-11-10 17:47 ` Rudy Rigot
2022-11-10 20:04 ` [PATCH v5] " Rudy Rigot via GitGitGadget
2022-11-15 16:39 ` Jeff Hostetler
2022-11-15 16:42 ` Rudy Rigot
2022-11-15 17:26 ` Eric Sunshine
2022-11-15 17:45 ` Rudy Rigot
2022-11-15 18:06 ` Eric Sunshine [this message]
2022-11-15 18:08 ` Rudy Rigot
2022-11-15 21:19 ` [PATCH v6] " Rudy Rigot via GitGitGadget
2022-11-21 5:06 ` Eric Sunshine
2022-11-21 15:54 ` Rudy Rigot
2022-11-21 16:17 ` Eric Sunshine
2022-11-22 16:52 ` Rudy Rigot
2022-11-22 17:18 ` Eric Sunshine
2022-11-22 17:24 ` Eric Sunshine
2022-11-22 17:29 ` Rudy Rigot
2022-11-22 17:40 ` Eric Sunshine
2022-11-22 18:07 ` Eric Sunshine
2022-11-22 19:19 ` Rudy Rigot
2022-11-22 19:48 ` Eric Sunshine
2022-11-22 16:59 ` [PATCH v7] status: modernize git-status "slow untracked files" advice Rudy Rigot via GitGitGadget
2022-11-22 22:07 ` [PATCH v8] " Rudy Rigot via GitGitGadget
2022-11-25 4:58 ` Junio C Hamano
2022-11-29 15:21 ` Rudy Rigot
2022-11-30 0:51 ` Rudy Rigot
2022-11-30 0:52 ` [PATCH v9] " Rudy Rigot via GitGitGadget
2022-12-01 6:48 ` Junio C Hamano
2022-12-01 15:16 ` Rudy Rigot
2022-12-01 22:45 ` Junio C Hamano
2022-12-01 22:57 ` Rudy Rigot
2023-05-11 5:17 ` [PATCH v8] " Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cT2+nitwD64FzG=6FvO7eUn3q-cq_CmmYeOXxOMyzvUnw@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=avarab@gmail.com \
--cc=derrickstolee@github.com \
--cc=git@jeffhostetler.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=me@ttaylorr.com \
--cc=rudy.rigot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).