From: Eric Sunshine <firstname.lastname@example.org> To: Josh Soref <email@example.com> Cc: "gitgitgadget/git" <reply+AAQFMLC42KHLQTLKSC5H3XV6TILQ3EVBNHHDGQXBRY@reply.github.com>, Git List <firstname.lastname@example.org>, Junio C Hamano <email@example.com> Subject: Re: [gitgitgadget/git] git-merge: rewrite already up to date message (#934) Date: Sun, 2 May 2021 19:19:37 -0400 [thread overview] Message-ID: <CAPig+cSz6TDs6=URFcmi8w0zdvTKV9k2346LHpiWbqKm4tXzRQ@mail.gmail.com> (raw) In-Reply-To: <CAPig+cS+b-SV6SUkhWMui7_vTEeJYumDDDM10DdrkNqpgm=z_A@mail.gmail.com> On Sun, May 2, 2021 at 2:52 AM Eric Sunshine <firstname.lastname@example.org> wrote: > On Sun, May 2, 2021 at 1:49 AM Josh Soref <email@example.com> wrote: > > Eric Sunshine wrote: > > > diff --git a/notes-merge.c b/notes-merge.c > > > - printf("Already up to date!\n"); > > > + printf_ln("Already up to date."); > > > > Should this have `_(...)` decorations? > > Yes, indeed. I'll fix it in a re-roll and mention it in the commit message. On second thought, I don't think I will make this change since none of the messages in `notes-merge.c` have been marked for localization yet -- and there are a lot of messages in that file -- so wrapping just this one message in `_(...)` would be inconsistent, and marking all messages in `notes-merge.c` as localizable is outside the scope of this series. So, at the moment, I don't plan on re-rolling this series, and hopefully Junio can pick it up as-is (but, of course, will re-roll if someone spots something which needs fixing).
next prev parent reply other threads:[~2021-05-02 23:19 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top [not found] <firstname.lastname@example.org> [not found] ` <email@example.com> 2021-05-02 5:49 ` Josh Soref 2021-05-02 6:52 ` Eric Sunshine 2021-05-02 23:19 ` Eric Sunshine [this message] 2021-05-03 1:13 ` Junio C Hamano
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAPig+cSz6TDs6=URFcmi8w0zdvTKV9k2346LHpiWbqKm4tXzRQ@mail.gmail.com' \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --cc=reply+AAQFMLC42KHLQTLKSC5H3XV6TILQ3EVBNHHDGQXBRY@reply.github.com \ --subject='Re: [gitgitgadget/git] git-merge: rewrite already up to date message (#934)' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://80x24.org/mirrors/git.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).