From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 07D641F953 for ; Wed, 24 Nov 2021 01:33:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233876AbhKXBg1 convert rfc822-to-8bit (ORCPT ); Tue, 23 Nov 2021 20:36:27 -0500 Received: from mail-ed1-f45.google.com ([209.85.208.45]:44634 "EHLO mail-ed1-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233736AbhKXBgW (ORCPT ); Tue, 23 Nov 2021 20:36:22 -0500 Received: by mail-ed1-f45.google.com with SMTP id l25so2768045eda.11 for ; Tue, 23 Nov 2021 17:33:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=EEjx9jMbkJdP+0Jc0btYcnc8axB9l49/+Pd0sOyBeu4=; b=BktrFn0aIuJcQ6+kQfT6qkwsIItrAqejeHl+4F8vZA+rz924GQsEZ6ouMmBJFAN6DH CmwPqzZDXo5kdUmsvsKTmZDSZ5jH/JnvBly4OF1xqjxEdFeuaghTCD1QjvbIiCKHo72J IYwNwkUzd7JkN6FfgUF0JCxakfN0ht3tnGobaMzyISvbl/2ySjoJmKgEdXKUg+PxiZ+N 0g/UV2UXJhQu7finibjjkqq7aQBLmklQtKfdhxOnNnisq0R9mFQk3p7YOqSW3Ez6KjSc DmtS29ja0uRpnIiVYztU/vYqlASRr1IQjccnkq70qfhIB9AyKafpjJ4Mn5qdjRqariAV WpOw== X-Gm-Message-State: AOAM533ChqQozQeMeM6E5ioyf3lAA/HOPVVskAkDqBmpkqbgXXhMsZET aKqRsiSSxNYqYDX32aBDIdE5/DCDS9WbZX2xZd/657RCXjg= X-Google-Smtp-Source: ABdhPJyCb9BIc1+Qs5mSdmv+8+NXP/fX0G889q/rHQMcYIrGKQpIZg6ij4VX2AbrC6YHOGvi/+wWUUK6mFVp2sT27Tw= X-Received: by 2002:a05:6402:2043:: with SMTP id bc3mr17683350edb.231.1637717593012; Tue, 23 Nov 2021 17:33:13 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Eric Sunshine Date: Tue, 23 Nov 2021 20:33:02 -0500 Message-ID: Subject: Re: [PATCH v2 4/9] run-command tests: use strvec_pushv(), not argv assignment To: =?UTF-8?B?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= Cc: Git List , Junio C Hamano , Jeff King , Enzo Matsumiya Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Nov 23, 2021 at 7:08 AM Ævar Arnfjörð Bjarmason wrote: > As in the preceding commit change this API user to use strvec_pushv() > instead of assigning to the "argv" member directly. This leaves is s/leaves is/leaves us/ > without test coverage of how the "argv" assignment in this API works, > but we'll be removing it in a subsequent commit. > > Signed-off-by: Ævar Arnfjörð Bjarmason