From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id E4F991F8C6 for ; Sat, 11 Sep 2021 07:41:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235401AbhIKHme convert rfc822-to-8bit (ORCPT ); Sat, 11 Sep 2021 03:42:34 -0400 Received: from mail-ej1-f51.google.com ([209.85.218.51]:36380 "EHLO mail-ej1-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233040AbhIKHmd (ORCPT ); Sat, 11 Sep 2021 03:42:33 -0400 Received: by mail-ej1-f51.google.com with SMTP id bt14so9095313ejb.3 for ; Sat, 11 Sep 2021 00:41:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=WoLtpfaga4lyqb+zt5zs6Vyz7CeTIffOtsRSTCytGyY=; b=yMlRT/rtRdYxVUWpYZIihCxPNaINLdghETerLb4QpYXrjhpn7iDIDavmEjHiS1V38l BVniDbbNtkVxJxl3OS+h3YBQF+zqRDYIw4CkNJONi7Wr8scrYlQtQTPyBjy1dMyIRaFr 1nM0JUyrI1JR09buOHsPJRpf19me17CcI3W1qkazq+MCDtKsype+wu8mbstwa1rIHFux TRsOfv3Y3feV6yZQVHijrhgOEU9IWdZ7eBKkxD23r1QOOojQWKuaqRCmgFtV/WZctCuN zsctNSFmIAa0JmcLohuDwaUGEbibGeSMk8fG2Qc8Lkt/GGj+cpJbJhIEiDYbgVLQsTj6 kWmg== X-Gm-Message-State: AOAM530yuU1Qjl12hytWYotIwT0zsZU86vVV0MwdczgsYmU3q/XBsrvG cdgnH7IJV9eKL972en6CCgGV5wzEbTfqjhseGscOH7k6 X-Google-Smtp-Source: ABdhPJxTL0M9lLzS7idF3bF4mqGvCaWF+4juIJvfFOIyRmkXpjHy/DvCzoDocfLmC+cPDkEZHpqOBMRCL2+1pwsNBBs= X-Received: by 2002:a17:906:318c:: with SMTP id 12mr1745592ejy.28.1631346080475; Sat, 11 Sep 2021 00:41:20 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Eric Sunshine Date: Sat, 11 Sep 2021 03:41:09 -0400 Message-ID: Subject: Re: [PATCH v2 0/6] parse-options: properly align continued usage output & related To: =?UTF-8?B?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= Cc: Git List , Junio C Hamano , Jeff King , Carlo Arenas Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Sep 10, 2021 at 11:38 AM Ævar Arnfjörð Bjarmason wrote: > This series changes usage_with_options_internal() in parse-options.c > to properly align continued "\n" usage output. > > This v2 now also gets rid of the support for "" in the usage string > array. Eric Sunshine had ideas[1] for how to simplify the code in v1, > along with a suggestion that we could just get rid of the "" from > "builtin/blame.c". To be clear, I only asked whether you really needed to add support for embedded newlines in free-form usage strings following a "" line; I didn't actually suggest dropping support for free-form text following a "" line. Perhaps I didn't articulate that well enough, though, in my review(?). Aside: I did, however, _think_ about suggesting that free-form text support be dropped since I only found one consumer of the feature, however, I decided not to make that suggestion since the feature seemed like it had potential value and the current implementation is good enough and simple enough (though undocumented, as far as I can tell).