From: Eric Sunshine <sunshine@sunshineco.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Git List <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/2] refs: warn on non-pseudoref looking .git/<file> refs
Date: Thu, 10 Dec 2020 15:47:30 -0500 [thread overview]
Message-ID: <CAPig+cSph9EcnGDUBjWsvR3yfbydK=mOMPmCEas=YC6bUJS=zA@mail.gmail.com> (raw)
In-Reply-To: <87sg8dwglk.fsf@evledraar.gmail.com>
On Thu, Dec 10, 2020 at 3:29 PM Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
> On Thu, Dec 10 2020, Eric Sunshine wrote:
> > On Thu, Dec 10, 2020 at 7:55 AM Ævar Arnfjörð Bjarmason
> > <avarab@gmail.com> wrote:
> >> + GIT_TEST_GETTEXT_POISON=false grep "like a pseudoref" err &&
> >
> > What is the purpose of assigning GIT_TEST_GETTEXT_POISON here?
>
> Since 6cdccfce1e0 (i18n: make GETTEXT_POISON a runtime option,
> 2018-11-08) we haven't needed to use the C_LOCALE_OUTPUT prerequisite
> for any new code, since we can just turn the poisoning off.
>
> I think we should just slowly refactor things away from that
> prerequisite and test_i18ngrep, which were only needed because it used
> to be a compile-time switch, but I haven't gotter around to that
> refactoring.
>
> In liue of that I think it makes more sense to always run the full test
> if possible, no matter what the GIT_TEST_* mode is.
I must be missing something. I've looked at 6cdccfce1e0 but I still
don't see how or why `GIT_TEST_GETTEXT_POISON=false` could affect the
simple `grep` invocation being done by this test. I could understand
if GIT_TEST_GETTEXT_POISON was applied to the invocation of a Git
command, but that's not the case here.
(I also notice that 6cdccfce1e0 only checks whether
GIT_TEST_GETTEXT_POISON is empty or not -- and the changes in
6cdccfce1e0 set GIT_TEST_GETTEXT_POISON to an empty value rather than
to "false", so I find myself doubly confused by this application of
GIT_TEST_GETTEXT_POISON to `grep`.)
next prev parent reply other threads:[~2020-12-10 20:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 12:53 [PATCH 1/2] refs: move is_pseudoref_syntax() earlier in the file Ævar Arnfjörð Bjarmason
2020-12-10 12:53 ` [PATCH 2/2] refs: warn on non-pseudoref looking .git/<file> refs Ævar Arnfjörð Bjarmason
2020-12-10 14:39 ` Eric Sunshine
2020-12-10 20:28 ` Ævar Arnfjörð Bjarmason
2020-12-10 20:47 ` Eric Sunshine [this message]
2020-12-10 22:17 ` Ævar Arnfjörð Bjarmason
2020-12-14 19:16 ` [PATCH v2 0/2] " Ævar Arnfjörð Bjarmason
2020-12-14 19:16 ` [PATCH v2 1/2] refs: move is_pseudoref_syntax() earlier in the file Ævar Arnfjörð Bjarmason
2020-12-14 19:17 ` [PATCH v2 2/2] refs: warn on non-pseudoref looking .git/<file> refs Ævar Arnfjörð Bjarmason
2020-12-14 19:56 ` Eric Sunshine
2020-12-14 22:44 ` Junio C Hamano
2020-12-15 23:07 ` Ævar Arnfjörð Bjarmason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cSph9EcnGDUBjWsvR3yfbydK=mOMPmCEas=YC6bUJS=zA@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).