From: Eric Sunshine <sunshine@sunshineco.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Theodore Dubois <tbodt@google.com>, Git List <git@vger.kernel.org>
Subject: Re: [PATCH v2] Propagate --quiet on submodule update to merge/rebase
Date: Wed, 30 Sep 2020 17:04:43 -0400 [thread overview]
Message-ID: <CAPig+cSoJf-=Po39qocKttH2TQNGW9wVov6cQgb5zbZjZz63Bw@mail.gmail.com> (raw)
In-Reply-To: <xmqqzh57f0dh.fsf@gitster.c.googlers.com>
On Wed, Sep 30, 2020 at 4:58 PM Junio C Hamano <gitster@pobox.com> wrote:
> Will queue with the following log message.
>
> submodule update: silence underlying merge/rebase "--quiet" is given
Probably want to insert "when" in there.
> Commands such as
>
> $ git pull --rebase --recurse-submodules --quiet
>
> produce non-quiet output from the merge or rebase. Pass the --quiet
> option down when invoking "rebase" and "merge".
>
> Also fix the parsing of git submodule update -v.
>
> When e84c3cf3 (git-submodule.sh: accept verbose flag in cmd_update
> to be non-quiet, 2018-08-14) taught "git submodule update" to take
> "--quiet", it apparently did not know how ${GIT_QUIET:+--quiet}
> works, and reviewers seem to have missed that setting the variable
> to "0" (instead of "1" which is used when "--quiet" is given) has
> the same effect to pass "--quiet" to underlying commands.
Perhaps:
... to "0", rather than unsetting it, still results in "--quiet"
being passed to underlying commands.
next prev parent reply other threads:[~2020-09-30 21:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 19:50 [PATCH v2] Propagate --quiet on submodule update to merge/rebase Theodore Dubois
2020-09-30 20:58 ` Junio C Hamano
2020-09-30 21:04 ` Eric Sunshine [this message]
2020-10-01 5:38 ` Jonathan Nieder
2020-10-01 15:49 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cSoJf-=Po39qocKttH2TQNGW9wVov6cQgb5zbZjZz63Bw@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=tbodt@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).