From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id CC5511F8C8 for ; Mon, 4 Oct 2021 02:53:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232285AbhJDCyy convert rfc822-to-8bit (ORCPT ); Sun, 3 Oct 2021 22:54:54 -0400 Received: from mail-ed1-f53.google.com ([209.85.208.53]:39443 "EHLO mail-ed1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232213AbhJDCyv (ORCPT ); Sun, 3 Oct 2021 22:54:51 -0400 Received: by mail-ed1-f53.google.com with SMTP id x7so57703540edd.6 for ; Sun, 03 Oct 2021 19:53:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=FajBJR/3IO0CXmc/KsQyURSGSrxxpwcjIcjyTDbk7SE=; b=idYd+yIt88//2YfAUdwr3oCK2OrP9iND/eEI5TndHZ6ugvL7c0Do2ExY4+UMHRRwnp i7keVIutQdnt4n35x9KZCk3QexGg+KC4vT+CM700QOy8osrhFyZKzkGwvmV+C1PyK2hZ 7zvuGI411DmoCTSWZKCeTSTdPXapA1BEPMii9Np3AUAytoqfcUcUL/DbegRrtBYphNQe BrmfVQWDTCkiuC086UOTEx9kU6MDXXyjCEPSNMMvgdQRi3pJZQ9NHgbwkjqxQ3WS2uvL 4QlKUOKUCg0Zlfqaw/QV/mOvlQ8fKud4Vunfyhusx1cM6BYMx0+4QwUZDejChXRwKxo8 KdVw== X-Gm-Message-State: AOAM533E7hdFxJeTyBHngZEUjuvb06Uf/Y6q3vD9cbVKwuXUwKLmOidb i8I0dgkq6Z1+dmtNovMRzfpm8tkwt407sTSqfN0= X-Google-Smtp-Source: ABdhPJwscu5+5yC/pRv3rrBl6YbbTKTSijKGeHyy80Ug17SZ71wUliUlhDHfq+IzNSTsWNs9i0ZNIhQ9Zt8wyKK6Fo8= X-Received: by 2002:aa7:d502:: with SMTP id y2mr9217007edq.231.1633315982261; Sun, 03 Oct 2021 19:53:02 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Eric Sunshine Date: Sun, 3 Oct 2021 22:52:51 -0400 Message-ID: Subject: Re: [PATCH 1/2] object-name tests: tighten up advise() output test To: =?UTF-8?B?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= Cc: Git List , Junio C Hamano , Jeff King Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Sun, Oct 3, 2021 at 9:43 PM Ævar Arnfjörð Bjarmason wrote: > Change tests added in 1ffa26c4614 (get_short_sha1: list ambiguous > objects on error, 2016-09-26) to only care about the OIDs that are > listed, which is what the test is trying to check for. > > This isn't needed by the subsequent commit, which won't change any of > the output, but a mere tightening of the tests assertions to more > closely match what we really want to test for here. > > Now if the advise() message itself were change the phrasing around the s/were change/were to change/ > list of OIDs we won't have this test break. We're assuming that such > output won't have a need to indent anything except the OIDs. > > Signed-off-by: Ævar Arnfjörð Bjarmason