From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS53758 23.128.96.0/24 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW, SPF_HELO_PASS,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 656CC1F8C6 for ; Tue, 22 Jun 2021 00:43:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230332AbhFVApu convert rfc822-to-8bit (ORCPT ); Mon, 21 Jun 2021 20:45:50 -0400 Received: from mail-ed1-f43.google.com ([209.85.208.43]:33639 "EHLO mail-ed1-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230318AbhFVApt (ORCPT ); Mon, 21 Jun 2021 20:45:49 -0400 Received: by mail-ed1-f43.google.com with SMTP id d7so21437470edx.0 for ; Mon, 21 Jun 2021 17:43:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=BdiJqDWsC8RJhGb65o3d8NJbLFGchh+cwwaA/DSm8dI=; b=uMwDjn1oSbmZ32pZiDpQkHFpgre0aohGiGQ4rAqQ+8C84fEvZ0Q85q7YZHUfKrSsdz NsV3mgNWwkXGbdsDkwjhjjuCO+WjlrGWRVYSDeB2+qoImCgrCHXl06JUvbXD/XYtsJoT gj9oQwZkeFsoAV1xD742jrSA5B8uUnyMa7hnQyDZIUFVjnC+auolDNpe1blv2mjvW5KY kTTgdynZHywv6kXx1xsWgf6x6ou2XtnZi/3r2FYQyuY6KW7b3uOyq1folH4FuymacE2w wvoHF9SWU6fXMX5TrQGGUzLOeCOflga5KGThQEnvygbP05TUleGuzWc+7NLgyxUz56oL saGg== X-Gm-Message-State: AOAM533M9NXpANJlzCTmJVZIw3r/zauxqZSB1rjK9oz8jeFmlGa8JVwx IK19fsSREBWrnZv+EAj5Q7YFz56i+cYwIu/YfrY= X-Google-Smtp-Source: ABdhPJxXXpDhswt9HtvjMiibgmzyC9gpei7M3/aOk9eLKjYd7tBYn5SUXP+5V48B8L6vD2lr6fT3KfgN0kV7KV5nHKo= X-Received: by 2002:a50:9d8d:: with SMTP id w13mr1360503ede.94.1624322612822; Mon, 21 Jun 2021 17:43:32 -0700 (PDT) MIME-Version: 1.0 References: <20210615172038.28917-1-congdanhqx@gmail.com> <20210619013035.26313-1-congdanhqx@gmail.com> In-Reply-To: From: Eric Sunshine Date: Mon, 21 Jun 2021 20:43:22 -0400 Message-ID: Subject: Re: [PATCH v3 0/4] t: new helper test_line_count_cmd To: =?UTF-8?B?xJBvw6BuIFRy4bqnbiBDw7RuZyBEYW5o?= Cc: Junio C Hamano , Git List , =?UTF-8?B?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= , Bagas Sanjaya , Phillip Wood , Felipe Contreras Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Jun 21, 2021 at 7:52 PM Đoàn Trần Công Danh wrote: > On 2021-06-19 15:50:17+0900, Junio C Hamano wrote: > > Eric Sunshine writes: > > > Indeed, I have no problem seeing this as a new mode of > > > test_line_count() triggered by an option. In fact, I suggested exactly > > > that[1] when this idea first arose (except I named the option `-c` > > > rather than `-e`, but the latter is fine). However, my suggestion was > > > pretty much shot down[2] (and I don't entirely disagree with [2], > > > which is why I didn't pursue the idea in [1]). > > > > Yeah, I still am skeptical that we'd gain much by hiding the > > redirection to >actual behind the helper, so as I said in response > > to the v2 series, I am fine without this new helper or an enhanced > > test_line_count, but go with more use of test_must_be_empty etc. > > I guess the overall feedback for this new helper is negative. > I think the consensus here is a local helper in t640{0,2} for counting > ls-files? A local specialized function makes sense to me.