From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_PASS, SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by dcvr.yhbt.net (Postfix) with ESMTP id 706E01F990 for ; Thu, 6 Aug 2020 20:26:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726058AbgHFU02 convert rfc822-to-8bit (ORCPT ); Thu, 6 Aug 2020 16:26:28 -0400 Received: from mail-wm1-f66.google.com ([209.85.128.66]:38029 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725812AbgHFU02 (ORCPT ); Thu, 6 Aug 2020 16:26:28 -0400 Received: by mail-wm1-f66.google.com with SMTP id t14so10884694wmi.3 for ; Thu, 06 Aug 2020 13:26:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Fy/w9iTkP0R123Ze5+ISs2YvR3hW8SYDatTXh0UonyM=; b=QF3HcS34qmdC1AeLor7spSWtlpUsoqydcadz8sCLHi6Vb3oEZbNDp6jtuHZX/GW4v9 WRV2T46kJprSmWcCeNE0y4o0wxpKWiTUmgCJMpMQUetiTTzlaa5G54mGDvNgiJ0sELHS 1QFC1rnAPhqk80PEPUqlHKpacpD/6eg0jKGbYlzvHCgLsKe9xJqloEQiZ9meUxJNro/+ bKDLDG1Zjqbn8sXR/8vamzpaWvvqitFAglQR+tZXcDFTCC01Hrwd/4JienxDMKnG/xwu 5n0ZIO/z+CZmEIv4zPq+nlQsA6aMvJWSNn8hfkJGBLh+H8gZaUomjO1egDZn38HBtORc Rg/w== X-Gm-Message-State: AOAM532oHTcJO3S7+qIbYrMVgzxvcasfgxzLCy0pJc0VwMyQ+SuaFUL4 DjDqKQ5zEBms1GA/ho7Q0GO5vygapfQhhjwfqGc= X-Google-Smtp-Source: ABdhPJxyHSNx8kG0RJyHzIp9PqGk8lMtkvlpjPG8QcNv+PJiIEFjvs5ah5Ml37ATUMSnUfc3c57W+QW3+6tYABm4rsg= X-Received: by 2002:a1c:e304:: with SMTP id a4mr9403379wmh.11.1596745586045; Thu, 06 Aug 2020 13:26:26 -0700 (PDT) MIME-Version: 1.0 References: <20200802143018.5501-1-martin.agren@gmail.com> In-Reply-To: From: Eric Sunshine Date: Thu, 6 Aug 2020 16:26:15 -0400 Message-ID: Subject: Re: [PATCH v2 1/2] t: don't spuriously close and reopen quotes To: =?UTF-8?Q?Martin_=C3=85gren?= Cc: Git List , Junio C Hamano , Chris Torek Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Thu, Aug 6, 2020 at 4:09 PM Martin Ågren wrote: > diff --git a/t/t4200-rerere.sh b/t/t4200-rerere.sh > @@ -364,7 +364,7 @@ test_expect_success 'set up an unresolved merge' ' > fifth=$(git rev-parse fifth) && > - echo "$fifth branch 'fifth' of ." | > + echo "$fifth branch fifth of ." | > git fmt-merge-msg >msg && This one is a bit weird. It really seems as if the intent was to quote the word "fifth" in the merge message, so dropping the quotes altogether seems wrong. However, the file 'msg' is never even consulted in this test (or any other test), so is this just "dead code" (including the leading 'fifth=' assignment which also is otherwise unused outside the 'echo')? > diff --git a/t/t5510-fetch.sh b/t/t5510-fetch.sh > @@ -213,7 +213,7 @@ test_expect_success 'fetch tags when there is no tags' ' > test_expect_success 'fetch following tags' ' > cd "$D" && > - git tag -a -m 'annotated' anno HEAD && > + git tag -a -m "annotated" anno HEAD && There are a fair number of these quoted single-token arguments containing no special characters which don't actually need to be quoted at all, so an alternative would be simply to drop the quotes altogether, making the commands less syntactically noisy. However, that might be outside the intended scope of this change.