git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
	Git List <git@vger.kernel.org>, Duy Nguyen <pclouds@gmail.com>,
	Antoine Pelisse <apelisse@gmail.com>
Subject: Re: [PATCH v2 3/4] t4203: test mailmap functionality directly rather than indirectly
Date: Fri, 12 Jul 2013 02:05:18 -0400	[thread overview]
Message-ID: <CAPig+cSfqONOFmmXX=s+HWKnLr5eG27jU9xgE7Dki0sycPPz1g@mail.gmail.com> (raw)
In-Reply-To: <7v7ggwpbut.fsf@alter.siamese.dyndns.org>

On Fri, Jul 12, 2013 at 1:48 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Jonathan Nieder <jrnieder@gmail.com> writes:
>
>> My current thinking is "no" --- the patch has as a justification "Now
>> we can test these aspects of .mailmap handling directly with a
>> low-level tool instead of using the tool most people will use, so do
>> so", which sounds an awful lot like "Reduce test coverage of commonly
>> used tools, because we can".
>
> Yes, that was exactly my reaction that prompted my response.

Does any of my follow-up commentary result in a different reaction? If
not, I'll drop patches 3 &4 in the re-roll.

  reply	other threads:[~2013-07-12  6:05 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-11 14:55 [PATCH v2 0/4] add git-check-mailmap command Eric Sunshine
2013-07-11 14:55 ` [PATCH v2 1/4] builtin: " Eric Sunshine
2013-07-11 19:04   ` Junio C Hamano
2013-07-12  3:28     ` Eric Sunshine
2013-07-12  5:47       ` Junio C Hamano
2013-07-12  6:24         ` Eric Sunshine
2013-07-12  6:34           ` Junio C Hamano
2013-07-12  6:39             ` Eric Sunshine
2013-07-11 14:55 ` [PATCH v2 2/4] t4203: test check-mailmap command invocation Eric Sunshine
2013-07-11 14:55 ` [PATCH v2 3/4] t4203: test mailmap functionality directly rather than indirectly Eric Sunshine
2013-07-11 19:07   ` Junio C Hamano
2013-07-12  0:35     ` Eric Sunshine
2013-07-12  0:55       ` Jonathan Nieder
2013-07-12  2:37         ` Eric Sunshine
2013-07-12  5:48         ` Junio C Hamano
2013-07-12  6:05           ` Eric Sunshine [this message]
2013-07-12  6:25             ` Junio C Hamano
2013-07-11 14:55 ` [PATCH v2 4/4] t4203: consolidate test-repository setup Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPig+cSfqONOFmmXX=s+HWKnLr5eG27jU9xgE7Dki0sycPPz1g@mail.gmail.com' \
    --to=sunshine@sunshineco.com \
    --cc=apelisse@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    --cc=pclouds@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).