From: Eric Sunshine <sunshine@sunshineco.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Sanchit Jindal via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Sanchit Jindal <sanchit1053@gmail.com>
Subject: Re: [PATCH] t9803-git-p4-shell-metachars.sh: update to use test_path_* functions
Date: Wed, 20 Mar 2024 17:06:10 -0400 [thread overview]
Message-ID: <CAPig+cSYP=_UirE8nDEoMDX1_GuTVFPt1wrbonYN848xPMZBvw@mail.gmail.com> (raw)
In-Reply-To: <xmqqle6cfx81.fsf@gitster.g>
On Wed, Mar 20, 2024 at 4:46 PM Junio C Hamano <gitster@pobox.com> wrote:
> A few minor points.
>
> * As our test numbers uniquely identify test scripts, your commit
> title can be "t9803: use test_path_* helpers".
I meant to mention this, as well, in my review but forgot.
prev parent reply other threads:[~2024-03-20 21:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 19:48 [PATCH] t9803-git-p4-shell-metachars.sh: update to use test_path_* functions Sanchit Jindal via GitGitGadget
2024-03-20 20:35 ` Eric Sunshine
2024-03-20 20:46 ` Junio C Hamano
2024-03-20 21:06 ` Eric Sunshine [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cSYP=_UirE8nDEoMDX1_GuTVFPt1wrbonYN848xPMZBvw@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=sanchit1053@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).