From: Eric Sunshine <sunshine@sunshineco.com>
To: Andreas Hasenack <andreas@canonical.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Andreas Hasenack via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] chainlint.pl: fix /proc/cpuinfo regexp
Date: Wed, 23 Nov 2022 10:52:48 -0500 [thread overview]
Message-ID: <CAPig+cSVjnrHEZxosbS1Au7LRbDRZt_r9dr78S37FPXdb3W2QA@mail.gmail.com> (raw)
In-Reply-To: <CANYNYEETCaaQGOXVLrRCC8wdS-uD66BHqr98Eetb+1GVk5WkTg@mail.gmail.com>
On Wed, Nov 23, 2022 at 7:17 AM Andreas Hasenack <andreas@canonical.com> wrote:
> Should I still change the commit message regarding where I mention the
> commit that introduced this, as explained by Eric? From the activity I
> saw overnight it looks like things were already picked up and it
> doesn't matter anymore.
No need to resend. Junio tweaked the commit message[1] when he picked
up the patch.
[1]: https://github.com/git/git/commit/1f51b77f4f3f4d05f249f80713b2969e4069c109
next prev parent reply other threads:[~2022-11-23 15:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-22 20:27 [PATCH] chainlint.pl: fix /proc/cpuinfo regexp Andreas Hasenack via GitGitGadget
2022-11-22 20:57 ` Eric Sunshine
2022-11-23 1:21 ` Junio C Hamano
2022-11-23 12:16 ` Andreas Hasenack
2022-11-23 15:52 ` Eric Sunshine [this message]
2022-11-23 23:53 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cSVjnrHEZxosbS1Au7LRbDRZt_r9dr78S37FPXdb3W2QA@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=andreas@canonical.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).