git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Eric Sunshine <sunshine@sunshineco.com>
To: Elijah Newren <newren@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: Anyone know what is creating commits with bogus dates?
Date: Thu, 21 May 2020 14:12:09 -0400	[thread overview]
Message-ID: <CAPig+cSQoWuVyrOMynPUueYPaij6wgq8owwk-U9wE=wmVMNyRQ@mail.gmail.com> (raw)
In-Reply-To: <CABPp-BFfa6q96qMUN07Dq3di6d3WuUzhyktBytbX=FGgarXgjg@mail.gmail.com>

On Thu, May 21, 2020 at 1:49 PM Elijah Newren <newren@gmail.com> wrote:
> I first discovered such a repository in the wild a while ago with
> rails.git.  It has a commit with a recorded timezone of "+051800" for
> both author and committer.  Everything else about the commit looks
> fine.  See https://github.com/rails/rails/commit/4cf94979c9f4d6683c9338d694d5eb3106a4e734.
>
> Some google searches at the time turned up a few other examples, all
> with the same "+051800" issue.  I put a special workaround for it into
> filter-repo because I figured it was slightly prominent but probably
> limited to that special timezone.  The fact that it was six digits but
> the last two were zeros made it seem not quite as bad as it could be.

In git.git itself, there were a couple bugs fixed [1,2] in which the
author header lacked a NUL-terminator after the timezone and in which
an error condition wasn't checked which led to the last digit of the
timezone being duplicated, however, if I recall correctly, those only
cropped up with "git rebase -i --root" (and only the author date-stamp
was affected), which doesn't seem to correspond to the cases you're
fixing.

Perhaps those commits were created by tools other than git.git?

[1]: ca3e1826a0 (sequencer: fix "rebase -i --root" corrupting author
header, 2018-07-31)
[2]: 0f16c09aae (sequencer: fix "rebase -i --root" corrupting author
header timezone, 2018-07-31)

  reply	other threads:[~2020-05-21 18:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-21 17:49 Anyone know what is creating commits with bogus dates? Elijah Newren
2020-05-21 18:12 ` Eric Sunshine [this message]
2020-05-21 18:57 ` Jeff King
2020-05-21 19:31   ` Elijah Newren
2020-05-21 19:55     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAPig+cSQoWuVyrOMynPUueYPaij6wgq8owwk-U9wE=wmVMNyRQ@mail.gmail.com' \
    --to=sunshine@sunshineco.com \
    --cc=git@vger.kernel.org \
    --cc=newren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).