From: Eric Sunshine <sunshine@sunshineco.com>
To: Brandon Williams <bmwill@google.com>
Cc: Git List <git@vger.kernel.org>, Ben Boeckel <ben.boeckel@kitware.com>
Subject: Re: [PATCH] diff-tree: read the index so attribute checks work in bare repositories
Date: Wed, 6 Dec 2017 17:07:21 -0500 [thread overview]
Message-ID: <CAPig+cSNwPJkVNNbnp-rh-jXgwrEXhvzVHZoQM6wQMQNjn5n5Q@mail.gmail.com> (raw)
In-Reply-To: <20171206220055.GB118027@google.com>
On Wed, Dec 6, 2017 at 5:00 PM, Brandon Williams <bmwill@google.com> wrote:
> On 12/05, Eric Sunshine wrote:
>> 557a5998d (submodule: remove gitmodules_config, 2017-08-03) touched a
>> fair number of built-in commands. It's not clear from the current
>> patch's commit message if diff-tree is the only command which
>> regressed. Is it? Or are other commands also likely to have regressed?
>> Perhaps the commit message could say something about this. For
>> instance: "All other commands touched by 557a5998d have been audited
>> and were found to be regression-free" or "Other commands may regress
>> in the same way, but we will take a wait-and-see attitude and fix them
>> as needed because <fill-in-reason>".
>
> I don't know if any other commands have regressed. This was such an odd
> regression that I think it would be difficult to say for certain that
> there couldn't be others. I did go through the affected builtins to see
> if I could find anything. I came up empty handed so I think we should
> be ok.
Thanks for the response. It would be nice to have this explained in
the commit message so that future readers don't have to wonder about
it.
next prev parent reply other threads:[~2017-12-06 22:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-04 21:22 gitattributes not read for diff-tree anymore in 2.15? Ben Boeckel
2017-12-04 23:03 ` Brandon Williams
2017-12-05 15:42 ` Ben Boeckel
2017-12-05 18:16 ` Brandon Williams
2017-12-05 19:48 ` Ben Boeckel
2017-12-05 22:13 ` [PATCH] diff-tree: read the index so attribute checks work in bare repositories Brandon Williams
2017-12-05 22:29 ` Ben Boeckel
2017-12-05 22:31 ` Brandon Williams
2017-12-05 23:13 ` Junio C Hamano
2017-12-05 23:14 ` Stefan Beller
2017-12-06 21:47 ` Brandon Williams
2017-12-05 23:25 ` Eric Sunshine
2017-12-06 22:00 ` Brandon Williams
2017-12-06 22:07 ` Eric Sunshine [this message]
2017-12-06 22:02 ` [PATCH v2] " Brandon Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cSNwPJkVNNbnp-rh-jXgwrEXhvzVHZoQM6wQMQNjn5n5Q@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=ben.boeckel@kitware.com \
--cc=bmwill@google.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).