From: Eric Sunshine <sunshine@sunshineco.com>
To: Bert Wesarg <bert.wesarg@googlemail.com>
Cc: Git List <git@vger.kernel.org>,
me@yadavpratyush.com,
Birger Skogeng Pedersen <birger.sp@gmail.com>
Subject: Re: [PATCH 1/2] git-gui: warn if the commit message contains lines longer than the set limit
Date: Wed, 4 Sep 2019 16:29:52 -0400 [thread overview]
Message-ID: <CAPig+cSL0fpc5cVgO1soAksD2b5xadkDLG+JxiDCi5s95VRU_A@mail.gmail.com> (raw)
In-Reply-To: <7da71d89f9fa987eca2e25974e4cec382c146e44.1567627609.git.bert.wesarg@googlemail.com>
On Wed, Sep 4, 2019 at 4:10 PM Bert Wesarg <bert.wesarg@googlemail.com> wrote:
> The commit message widget does not wrap the next and has a configurable
s/next/text/
> fixed width to avoid creating too wide commit messages. Though this was
> only enforced in the GUI. Now we also check the commit message at commit
> time for long lines and ask the author for confirmation if it exceeds the
> configured line length.
Hmm, more confirmation dialogs tend to mean more annoyance for users,
especially considering that the line length limit is a
project-specific _policy_ (so this has the potential to annoy a lot of
people), and also because there often are legitimate reasons for
exceeding the limit (such as pasting in URLs).
As an alternative to a confirmation dialog, how about instead adding a
_warning_ message (perhaps with red text) on the window itself
alongside to the commit message field (below or above it or
something)? Is that something that could be triggered by a text widget
callback?
> Signed-off-by: Bert Wesarg <bert.wesarg@googlemail.com>
> ---
> diff --git a/lib/commit.tcl b/lib/commit.tcl
> @@ -215,6 +215,16 @@ A good commit message has the following format:
> + if {[tcl::mathfunc::max {*}[lmap x [split $msg "\n"] {string length $x}]] >= $repo_config(gui.commitmsgwidth) \
Does this take TABs into account?
next prev parent reply other threads:[~2019-09-04 20:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 20:10 [PATCH 1/2] git-gui: warn if the commit message contains lines longer than the set limit Bert Wesarg
2019-09-04 20:10 ` [PATCH 2/2] git-gui: add horizontal scrollbar to commit buffer Bert Wesarg
2019-09-04 20:31 ` Eric Sunshine
2019-09-04 20:46 ` Bert Wesarg
2019-09-10 20:28 ` Pratyush Yadav
2019-09-12 19:10 ` Bert Wesarg
2019-09-04 20:29 ` Eric Sunshine [this message]
2019-09-04 20:43 ` [PATCH 1/2] git-gui: warn if the commit message contains lines longer than the set limit Bert Wesarg
2019-09-04 22:48 ` Pratyush Yadav
2019-09-05 6:48 ` Birger Skogeng Pedersen
2019-09-05 17:46 ` Bert Wesarg
2019-09-06 14:08 ` Birger Skogeng Pedersen
2019-09-06 20:07 ` Philip Oakley
2019-09-10 8:04 ` David Aguilar
2019-09-10 19:42 ` Pratyush Yadav
2019-09-05 6:21 ` Johannes Sixt
2019-09-05 17:43 ` Bert Wesarg
2019-09-10 16:50 ` Johannes Sixt
2019-09-12 19:26 ` Bert Wesarg
2019-09-10 20:34 ` Pratyush Yadav
2019-09-12 19:13 ` Bert Wesarg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cSL0fpc5cVgO1soAksD2b5xadkDLG+JxiDCi5s95VRU_A@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=bert.wesarg@googlemail.com \
--cc=birger.sp@gmail.com \
--cc=git@vger.kernel.org \
--cc=me@yadavpratyush.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).