From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.8 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from out1.vger.email (out1.vger.email [IPv6:2620:137:e000::1:20]) by dcvr.yhbt.net (Postfix) with ESMTP id 1C0A91F910 for ; Tue, 15 Nov 2022 20:58:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238564AbiKOU6Q (ORCPT ); Tue, 15 Nov 2022 15:58:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231731AbiKOU6P (ORCPT ); Tue, 15 Nov 2022 15:58:15 -0500 Received: from mail-il1-f171.google.com (mail-il1-f171.google.com [209.85.166.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54F521C403 for ; Tue, 15 Nov 2022 12:58:14 -0800 (PST) Received: by mail-il1-f171.google.com with SMTP id o13so8076144ilc.7 for ; Tue, 15 Nov 2022 12:58:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AUe3HFvYnQNJZibuSFmwu3eAaYo8yLV0HC3WDZB4X4w=; b=au/7DdRmJlnD2f+nSJTcAuTDhSvztOhpr521y/8OekTt4xAphfEQiEBA7EtQjQjse7 gaDqLRyTViQge6vreK2oxuOYAONfYq1F3GkoCsuMmxzU/A7+rwkAXsmdmt9wA5cBjvAG f9o7MX5WIMj/xTjzL1uHYj6u++PW28SqxaLzqYLJbEncOXKHB1WMtMhOlgJIn61UTcvq TCID+4omLPic/Oyqs32WFJB3+7EICACRlzr0QwvblCKI+42hrU/2XuDvpSqbJH+UFP6X rFk1txzzL47nbPpxdQ13P9NQANmW0z1S3TtZNCP5A8mJn2LTlXIzcq1NqS3OMJP4VsmU PJRQ== X-Gm-Message-State: ANoB5pk6v2jdbsNnTu7GK6sJwjKvA1g/HVF368zMqzK7j1IzQRl8LZHz NePlKDGb72ou5kdRTkJqh3UOaD9yWq2Veuvl0Mxeq8xcknA= X-Google-Smtp-Source: AA0mqf7wEIoBj0yWAuRIXg8mazITo+DmzNsa0X/iVCCPYkrFvZReg5wpLF9V9AxAZXSauUm86lfZdzE8+1EpztEJWMM= X-Received: by 2002:a92:2612:0:b0:302:557a:dba7 with SMTP id n18-20020a922612000000b00302557adba7mr6479733ile.249.1668545893547; Tue, 15 Nov 2022 12:58:13 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Eric Sunshine Date: Tue, 15 Nov 2022 15:58:02 -0500 Message-ID: Subject: Re: What's cooking in git.git (Nov 2022, #03; Mon, 14) To: Taylor Blau Cc: git@vger.kernel.org, Jacob Abel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Mon, Nov 14, 2022 at 11:53 PM Taylor Blau wrote: > * ja/worktree-orphan (2022-11-10) 2 commits > - worktree add: add --orphan flag > - worktree add: Include -B in usage docs > > 'git worktree add' learned how to create a worktree based on an > orphaned branch with `--orphan`. > > Waiting for review discussion to settle, but leaning negative. > source: <20221110233137.10414-1-jacobabel@nullpo.dev> I haven't had a chance yet to look at Jacob's v3, but this series does close a gap in worktree usability[*], and v3 addresses a stated concern of mine against earlier iterations, so I think a "negative lean" may not be warranted. [*] In particular, it is currently impossible to create a worktree from a brand new bare repository: % git init --bare foo.git % git -C foo.git worktree add -b main bar Preparing worktree (new branch 'main') fatal: not a valid object name: 'HEAD' % whereas, with this patch series: % git init --bare foo.git % git -C foo.git worktree add --orphan main bar Preparing worktree (new branch 'main') % (The commit message can probably be improved to spell this out since it wasn't obvious to me, simply from reading the commit message, that this problem existed.)