From: Eric Sunshine <sunshine@sunshineco.com>
To: Michael Forney <mforney@mforney.org>
Cc: Git List <git@vger.kernel.org>, Derrick Stolee <stolee@gmail.com>
Subject: Re: [PATCH 1/2] revision: use repository from rev_info when parsing commits
Date: Tue, 23 Jun 2020 17:24:34 -0400 [thread overview]
Message-ID: <CAPig+cSDxTjLbFWGMZuGuCDcZ05fnaJR0q-TA9DpKTki2M7MyQ@mail.gmail.com> (raw)
In-Reply-To: <20200623205659.14297-1-mforney@mforney.org>
On Tue, Jun 23, 2020 at 5:02 PM Michael Forney <mforney@mforney.org> wrote:
> This is needed when repo_init_revisions() is called with a repository
> that is not the_repository to ensure appropriate repository is used
> in repo_parse_commit_internal(). If the wrong repository is used,
> a fatal error is the commit-graph machinery occurs:
s/is/in/
> fatal: invalid commit position. commit-graph is likely corrupt
>
> Since revision.c was the only user of the parse_commit_gently
> compatibility define, remove it from commit.h.
>
> Signed-off-by: Michael Forney <mforney@mforney.org>
next prev parent reply other threads:[~2020-06-23 21:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 20:56 [PATCH 1/2] revision: use repository from rev_info when parsing commits Michael Forney
2020-06-23 20:56 ` [PATCH 2/2] submodule: use submodule repository when preparing summary Michael Forney
2020-06-24 14:35 ` Derrick Stolee
2020-06-24 16:12 ` Junio C Hamano
2020-06-30 11:04 ` Michael Forney
2020-08-13 21:16 ` Michael Forney
2020-06-23 21:24 ` Eric Sunshine [this message]
2020-06-24 14:29 ` [PATCH 1/2] revision: use repository from rev_info when parsing commits Derrick Stolee
2020-09-03 21:58 ` Junio C Hamano
2020-09-04 12:19 ` Derrick Stolee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cSDxTjLbFWGMZuGuCDcZ05fnaJR0q-TA9DpKTki2M7MyQ@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=mforney@mforney.org \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).