From: Eric Sunshine <sunshine@sunshineco.com>
To: Phillip Wood <phillip.wood@dunelm.org.uk>
Cc: Junio C Hamano <gitster@pobox.com>,
Git List <git@vger.kernel.org>,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: What's cooking in git.git (Aug 2018, #04; Fri, 17)
Date: Mon, 20 Aug 2018 13:44:53 -0400 [thread overview]
Message-ID: <CAPig+cS591C+A5zTMwaYFmq+_SCvmY7RUHeDn6sRvMbqKDke-A@mail.gmail.com> (raw)
In-Reply-To: <7b340c01-f57d-1a71-e4d5-0346bb042d0c@talktalk.net>
On Mon, Aug 20, 2018 at 6:23 AM Phillip Wood <phillip.wood@talktalk.net> wrote:
> On 17/08/2018 23:44, Junio C Hamano wrote:
> > * pw/rebase-i-author-script-fix (2018-08-07) 2 commits
> > - sequencer: fix quoting in write_author_script
> > - sequencer: handle errors from read_author_ident()
> >
> > Undecided.
> > Is it the list consensus to favor this "with extra code, read the
> > script written by bad writer" approach?
>
> I think there was agreement between myself and Eric on the last version,
> I'm not sure anyone else has expressed an opinion.
Phillip's v4 [1] does take backward-compatibility into account, but
with minimal extra code, which seems a reasonable compromise between
no backward-compatibility and the heavyweight approach of v3. I left a
few comments on v4 [1], but none were blockers, and changes based upon
those comments can be done later, so I think the series can move
forward.
[1]: https://public-inbox.org/git/20180807093452.22524-1-phillip.wood@talktalk.net/
next prev parent reply other threads:[~2018-08-20 17:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 22:44 What's cooking in git.git (Aug 2018, #04; Fri, 17) Junio C Hamano
2018-08-18 6:29 ` Duy Nguyen
2018-08-18 6:59 ` Jonathan Nieder
2018-08-20 17:26 ` Junio C Hamano
2018-08-20 18:14 ` Derrick Stolee
2018-08-18 9:34 ` Christian Couder
2018-08-18 11:34 ` Ævar Arnfjörð Bjarmason
2018-08-18 12:54 ` Christian Couder
2018-08-18 11:10 ` Ævar Arnfjörð Bjarmason
2018-08-20 10:23 ` Phillip Wood
2018-08-20 17:44 ` Eric Sunshine [this message]
2018-08-20 19:36 ` pw/rebase-i-author-script-fix, was " Johannes Schindelin
2018-08-20 18:11 ` Stefan Beller
2018-08-20 21:32 ` Junio C Hamano
2018-08-20 18:19 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cS591C+A5zTMwaYFmq+_SCvmY7RUHeDn6sRvMbqKDke-A@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).