From: Eric Sunshine <sunshine@sunshineco.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: Git List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Bert Wesarg <bert.wesarg@googlemail.com>,
Jeff King <peff@peff.net>,
Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH] remote: add meaningful exit code on missing/existing
Date: Mon, 26 Oct 2020 10:52:36 -0400 [thread overview]
Message-ID: <CAPig+cRvCPaUxoCojiHvwte4Ty9iRmOaYGrcKs7WHXQN=bid6g@mail.gmail.com> (raw)
In-Reply-To: <20201026144825.26537-1-avarab@gmail.com>
On Mon, Oct 26, 2020 at 10:48 AM Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
> Change the exit code for the likes of "git remote add/rename" to exit
> with 2 if the remote in question doesn't exist, and 3 if it
> does. Before we'd just die() and exit with the general 128 exit code.
> [...]
> So e.g. if a sleep() is added right after the remote_is_configured()
> check in add() we'll clobber rermote.NAME.url, and add
s/rermote/remote/
> another (usually duplicate) remote.NAME.fetch entry (and other values,
> depending on invocation).
>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
next prev parent reply other threads:[~2020-10-26 14:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 14:48 [PATCH] remote: add meaningful exit code on missing/existing Ævar Arnfjörð Bjarmason
2020-10-26 14:52 ` Eric Sunshine [this message]
2020-10-26 18:29 ` Junio C Hamano
2020-10-26 19:45 ` Jeff King
2020-10-26 21:00 ` Junio C Hamano
2020-10-27 9:41 ` [PATCH v2] " Ævar Arnfjörð Bjarmason
2020-10-26 19:55 ` [PATCH] " Bert Wesarg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cRvCPaUxoCojiHvwte4Ty9iRmOaYGrcKs7WHXQN=bid6g@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=avarab@gmail.com \
--cc=bert.wesarg@googlemail.com \
--cc=chriscool@tuxfamily.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).