From: Eric Sunshine <sunshine@sunshineco.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH 0/4] Make check-{attr,ignore} -z consistent
Date: Fri, 12 Jul 2013 02:55:26 -0400 [thread overview]
Message-ID: <CAPig+cRuLpNzYaQQBe2Cw1Y4OQbMjM6YYJtuGcDyXAcy4fnBdw@mail.gmail.com> (raw)
In-Reply-To: <1373609927-3244-1-git-send-email-gitster@pobox.com>
On Fri, Jul 12, 2013 at 2:18 AM, Junio C Hamano <gitster@pobox.com> wrote:
> A command that has to deal with input/output that may contain LF
> needs to offer the "-z" (--nul-terminated-records) option, and if it
> does not support separate --nul-terminated-{input,output} options,
> the "-z" option should govern both input and output. A caller that
> uses "-z" knows that the paths it feeds to these commands as input
> may have LF that cannot be expressed in LF delimited input format,
> and the output from these commands do contain the same paths, so
> there is no way for their output to be expressed unambiguously for
> an input that requires "-z".
FWIW, applying to the entire series:
Reviewed-by: Eric Sunshine <sunshine@sunshineco.com>
> Unfortunately, "git check-attr -z" was broken and ignored the option
> on the output side. This is a backward-incompatible fix, so we may
> need to add a "checkAttr.brokenZ" configuration to allow people to
> keep the existing breakage on top of these fixes, and then flip the
> default at Git 2.0 boundary (sometime early next year).
>
> Credit goes to Eric Sunshine for finding this discrepancy
> ($gmane/230158).
>
> Junio C Hamano (4):
> check-ignore: the name of the character is NUL, not NULL
> check-attr: the name of the character is NUL, not NULL
> check-ignore -z: a single -z should apply to both input and output
> check-attr -z: a single -z should apply to both input and output
>
> Documentation/git-check-attr.txt | 9 +++++++--
> builtin/check-attr.c | 20 ++++++++++++++------
> builtin/check-ignore.c | 12 ++++++------
> 3 files changed, 27 insertions(+), 14 deletions(-)
>
> --
> 1.8.3.2-911-g2c4daa5
prev parent reply other threads:[~2013-07-12 6:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-12 6:18 [PATCH 0/4] Make check-{attr,ignore} -z consistent Junio C Hamano
2013-07-12 6:18 ` [PATCH 1/4] check-ignore: the name of the character is NUL, not NULL Junio C Hamano
2013-07-12 6:18 ` [PATCH 2/4] check-attr: " Junio C Hamano
2013-07-12 6:18 ` [PATCH 3/4] check-ignore -z: a single -z should apply to both input and output Junio C Hamano
2013-07-12 6:18 ` [PATCH 4/4] check-attr " Junio C Hamano
2013-07-12 6:55 ` Eric Sunshine [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPig+cRuLpNzYaQQBe2Cw1Y4OQbMjM6YYJtuGcDyXAcy4fnBdw@mail.gmail.com \
--to=sunshine@sunshineco.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).