From: Eric Sunshine <sunshine@sunshineco.com>
To: Birger Skogeng Pedersen <birgersp@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH] git-gui: bind CTRL/CMD+numpad ENTER to do_commit
Date: Thu, 1 Mar 2018 13:31:06 -0500 [thread overview]
Message-ID: <CAPig+cRt+u4yEnFLM3kUB_J54Xvt6V9ceb6rwqfHC3kb=fttGg@mail.gmail.com> (raw)
In-Reply-To: <20180301143904.28652-1-birgersp@gmail.com>
On Thu, Mar 1, 2018 at 9:39 AM, Birger Skogeng Pedersen
<birgersp@gmail.com> wrote:
> ---
Please sign-off on your patch. See Documentation/SubmittingPatches.
Also, it would be helpful to write at least a short commit message
justifying the change. The reason you gave in your lead-in email[1]
might be sufficient:
In git-gui, we can hit CTRL/CMD+ENTER to create a commit. However,
using the numpad ENTER does not invoke the same command.
(assuming people don't argue that numpad ENTER should be saved for
some other function).
Thanks.
[1]: https://public-inbox.org/git/CAGr--=LxMtz5RRP4742u3VsrADRsWARE2SitCSOWATySOn2LcQ@mail.gmail.com/
> diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
> index 91c00e648..6de74ce63 100755
> --- a/git-gui/git-gui.sh
> +++ b/git-gui/git-gui.sh
> @@ -3867,6 +3867,7 @@ bind . <$M1B-Key-equal> {show_more_context;break}
> bind . <$M1B-Key-plus> {show_more_context;break}
> bind . <$M1B-Key-KP_Add> {show_more_context;break}
> bind . <$M1B-Key-Return> do_commit
> +bind . <$M1B-Key-KP_Enter> do_commit
> foreach i [list $ui_index $ui_workdir] {
> bind $i <Button-1> { toggle_or_diff click %W %x %y; break }
> bind $i <$M1B-Button-1> { add_one_to_selection %W %x %y; break }
next prev parent reply other threads:[~2018-03-01 18:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 14:25 git-gui: CTRL/CMD + numpad ENTER does not invoke same command as "regular" ENTER Birger Skogeng Pedersen
2018-03-01 14:39 ` [PATCH] git-gui: bind CTRL/CMD+numpad ENTER to do_commit Birger Skogeng Pedersen
2018-03-01 18:31 ` Eric Sunshine [this message]
2018-03-02 9:56 ` Birger Skogeng Pedersen
2018-03-02 10:01 ` [PATCH v2] " Birger Skogeng Pedersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cRt+u4yEnFLM3kUB_J54Xvt6V9ceb6rwqfHC3kb=fttGg@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=birgersp@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).